Disabled assigned ip box for multiple ips#1713
Merged
sarika-pf9 merged 1 commit intomainfrom Mar 18, 2026
Merged
Conversation
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
Comment on lines
+1114
to
+1119
| if (parseIpList(value).length > 1) { | ||
| setBulkPreserveIp((prev) => ({ | ||
| ...prev, | ||
| [vmName]: { ...prev[vmName], [interfaceIndex]: true } | ||
| })) | ||
| } |
Contributor
There was a problem hiding this comment.
In handleBulkIpChange, when multiple IPs are detected, the code forces preserveIp to true, but there's no check to prevent the user from later trying to disable it through other means. Consider adding a similar check in other functions that might modify the preserveIp state.
sarika-pf9
force-pushed
the
private/main/sarika/disble-toggle-for-multiple-ip
branch
from
f92e139 to
35f779d
Compare
sarika-pf9
deleted the
private/main/sarika/disble-toggle-for-multiple-ip
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
disabled assigned ip box for multiple ips
Which issue(s) this PR fixes
fixes #
Testing done