Skip to content

#1710 : Remove no ip validation in assign IP box for no ip interfaces#1712

Merged
AbhijeetThakur merged 1 commit intomainfrom
1710-remove-no-ip-validation-in-assign-ip-box-for-no-ip-interfaces
Mar 18, 2026
Merged

#1710 : Remove no ip validation in assign IP box for no ip interfaces#1712
AbhijeetThakur merged 1 commit intomainfrom
1710-remove-no-ip-validation-in-assign-ip-box-for-no-ip-interfaces

Conversation

@AbhijeetThakur
Copy link
Collaborator

What this PR does / why we need it

  • Allow an empty IP when Preserve IP is enabled, and no existing/source IP is discovered

Which issue(s) this PR fixes

fixes #

Testing done

Screencast.from.18-03-26.11.37.17.AM.IST.webm

Copy link
Contributor

@windsurf-bot windsurf-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🤙

💡 To request another review, post a new comment with "/windsurf-review".

Copy link
Collaborator

@OmkarDeshpande7 OmkarDeshpande7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AbhijeetThakur AbhijeetThakur merged commit d9db35d into main Mar 18, 2026
12 checks passed
@AbhijeetThakur AbhijeetThakur deleted the 1710-remove-no-ip-validation-in-assign-ip-box-for-no-ip-interfaces branch March 18, 2026 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove no ip validation in assign IP box for no ip interfaces

2 participants