#1692 : Support multiple IP addresses per network interface#1697
Open
AbhijeetThakur wants to merge 3 commits intomainfrom
Open
#1692 : Support multiple IP addresses per network interface#1697AbhijeetThakur wants to merge 3 commits intomainfrom
AbhijeetThakur wants to merge 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Other comments (2)
-
ui/src/features/migration/VmsSelectionStep.tsx (194-204)
The `normalizeNetworkInterfaces` function uses `any` type casting which bypasses TypeScript's type checking. Consider updating the function to use proper typing for better type safety.
const normalizeNetworkInterfaces = (networkInterfaces?: VmData['networkInterfaces']) => { if (!networkInterfaces || networkInterfaces.length === 0) return networkInterfaces return networkInterfaces.map((nic) => ({ ...nic, ipAddress: Array.isArray(nic.ipAddress) ? nic.ipAddress : nic.ipAddress ? [nic.ipAddress] : [] })) } - ui/src/features/migration/RollingMigrationForm.tsx (2749-2749) There's inconsistency in how empty IP values are handled. In some places you're setting `ipAddress: []` and in others you're checking if `ip.trim() !== ''`. For consistency, always use the empty array approach when there's no IP address.
💡 To request another review, post a new comment with "/windsurf-review".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
ipAddressfield in theVmNetworkInterfacemodel to accept an array of strings instead of just a single string. This change was applied across all migration templates and VMware machines.Which issue(s) this PR fixes
fixes #
Testing done
Screencast.from.16-03-26.10.50.54.PM.IST.webm