Skip to content

API change: multiple ips for single nic in vmwaremachines#1696

Merged
OmkarDeshpande7 merged 3 commits intomainfrom
private/main/omkard/multi-nic-multi-ip
Mar 17, 2026
Merged

API change: multiple ips for single nic in vmwaremachines#1696
OmkarDeshpande7 merged 3 commits intomainfrom
private/main/omkard/multi-nic-multi-ip

Conversation

@OmkarDeshpande7
Copy link
Collaborator

@OmkarDeshpande7 OmkarDeshpande7 commented Mar 16, 2026

What this PR does / why we need it

This PR changes the data type of IP per nic from string to slice. This is in the vmwaremachines object

Which issue(s) this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged)

fixes #1692

Special notes for your reviewer

Testing done

Screenshot 2026-03-17 at 10 51 17 AM

@OmkarDeshpande7 OmkarDeshpande7 marked this pull request as ready for review March 17, 2026 05:19
Copy link
Contributor

@windsurf-bot windsurf-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other comments (3)
  • deploy/00crds.yaml (3123-3125) This change from a string to an array of strings for `ipAddress` is a breaking API change. Make sure all controllers and client code that reads or writes this field are updated to handle the new array format. Consider adding migration logic or version-specific handling to maintain backward compatibility with existing resources.
  • deploy/installer.yaml (3123-3125) This change modifies the `ipAddress` field from a string to an array of strings, which is good for supporting multiple IPs per NIC. However, ensure that any code consuming this field is updated to handle the new array format to prevent runtime errors. Consider adding migration logic if there are existing resources using the old format.
  • k8s/migration/api/v1alpha1/vmwaremachine_types.go (92-92) Changing `IPAddress` from `string` to `[]string` is a breaking API change. Make sure to update all code that uses this field, including any code that might be unmarshaling JSON into this struct. Consider adding a migration path or version bump if this API is already in use.

💡 To request another review, post a new comment with "/windsurf-review".

@OmkarDeshpande7 OmkarDeshpande7 force-pushed the private/main/omkard/multi-nic-multi-ip branch from cca11c9 to af80f6a Compare March 17, 2026 05:22
@OmkarDeshpande7 OmkarDeshpande7 enabled auto-merge (squash) March 17, 2026 05:33
@OmkarDeshpande7 OmkarDeshpande7 force-pushed the private/main/omkard/multi-nic-multi-ip branch from 8eca62c to a3fa20e Compare March 17, 2026 05:49
@OmkarDeshpande7 OmkarDeshpande7 merged commit 5997713 into main Mar 17, 2026
12 checks passed
@OmkarDeshpande7 OmkarDeshpande7 deleted the private/main/omkard/multi-nic-multi-ip branch March 17, 2026 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve IP for a powered on VM is not getting IPs for multi IP interfaces

3 participants