API change: multiple ips for single nic in vmwaremachines#1696
Merged
OmkarDeshpande7 merged 3 commits intomainfrom Mar 17, 2026
Merged
API change: multiple ips for single nic in vmwaremachines#1696OmkarDeshpande7 merged 3 commits intomainfrom
OmkarDeshpande7 merged 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Other comments (3)
- deploy/00crds.yaml (3123-3125) This change from a string to an array of strings for `ipAddress` is a breaking API change. Make sure all controllers and client code that reads or writes this field are updated to handle the new array format. Consider adding migration logic or version-specific handling to maintain backward compatibility with existing resources.
- deploy/installer.yaml (3123-3125) This change modifies the `ipAddress` field from a string to an array of strings, which is good for supporting multiple IPs per NIC. However, ensure that any code consuming this field is updated to handle the new array format to prevent runtime errors. Consider adding migration logic if there are existing resources using the old format.
- k8s/migration/api/v1alpha1/vmwaremachine_types.go (92-92) Changing `IPAddress` from `string` to `[]string` is a breaking API change. Make sure to update all code that uses this field, including any code that might be unmarshaling JSON into this struct. Consider adding a migration path or version bump if this API is already in use.
💡 To request another review, post a new comment with "/windsurf-review".
k8s/migration/config/crd/bases/vjailbreak.k8s.pf9.io_vmwaremachines.yaml
Show resolved
Hide resolved
cca11c9 to
af80f6a
Compare
meghansh-pf9
approved these changes
Mar 17, 2026
8eca62c to
a3fa20e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR changes the data type of IP per nic from string to slice. This is in the vmwaremachines object
Which issue(s) this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged)fixes #1692
Special notes for your reviewer
Testing done