Draft
Conversation
Addressed PR review feedback by replacing error-prone script OS detection with backend validation that prevents users from using firstboot scripts when both Windows and Linux VMs are selected in the same migration plan. Changes: - Added ValidateMixedOSWithFirstboot() validation function - Validation checks for mixed OS types when firstboot script is provided - Returns clear error message suggesting alternatives: 1. Remove the firstboot script 2. Migrate Windows and Linux VMs separately 3. Create separate migration plans for each OS type This approach is more reliable than auto-detection and provides better user experience by catching the issue early during validation. Fixes issue mentioned in PR comments.
|
Cursor Agent can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR addresses previous review comments by replacing the error-prone auto-detection of firstboot script types with a robust backend validation. It prevents users from enabling firstboot scripts when a migration plan includes both Windows and Linux VMs, providing a clearer and more reliable approach.
Which issue(s) this PR fixes
fixes #
Special notes for your reviewer
ValidateMixedOSWithFirstboot()inmigrationplanutils.goto check for mixed OS types (Windows/Linux) when a firstboot script is present.migrationplan_controller.gonow calls this validation during migration plan processing.Testing done