Skip to content

[PCD-3023] Enable Alma Linux 10 Support in pcd-ctl#422

Merged
tanaypf9 merged 2 commits intomasterfrom
private/tanay/rocky
Sep 16, 2025
Merged

[PCD-3023] Enable Alma Linux 10 Support in pcd-ctl#422
tanaypf9 merged 2 commits intomasterfrom
private/tanay/rocky

Conversation

@tanaypf9
Copy link
Contributor

@tanaypf9 tanaypf9 commented Sep 9, 2025

ISSUE(S):

SUMMARY

ISSUE TYPE

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that may cause existing functionality to not work as expected)
  • This change requires a documentation update

IMPACTED FEATURES/COMPONENTS:

RELATED ISSUE(S):

DEPENDS ON:

TESTING DONE

Automated

Manual

Reviewers

Summary by Bito

This PR refactors CentOS platform code by renaming functions to Pascal-case for codebase consistency. Test files were updated to match these method name changes. Regex patterns in the constants file were enhanced to improve hostagent file name matching, contributing to better code reliability and maintainability.

@bito-code-review
Copy link
Contributor

Changelist by Bito

This pull request implements the following key changes.

Key Change Files Impacted
Feature Improvement - Improved Method Naming and Consistency in CentOS Platform

centos.go - Refactored method names from lower-case to Pascal-case (e.g., checkOSPackages to CheckOSPackages) for better consistency and clarity in the platform checks implementation.

Testing - Refactored Test Cases for Updated Methods

centos_test.go - Updated test cases to call the new Pascal-case method names and adjusted inline comments to maintain consistency with the refactored code.

Other Improvements - Regex Pattern Update for Hostagent Files

constants.go - Modified regex patterns to accommodate a broader range of file extensions for hostagent and comms packages, enhancing pattern matching robustness.

Copy link
Contributor

@bito-code-review bito-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Agent Run #fa40e3

Actionable Suggestions - 1
  • pkg/util/constants.go - 1
    • Overly generic regex pattern may match unintended files · Line 133-134
Review Details
  • Files reviewed - 3 · Commit Range: ef81a14..5d31b7d
    • pkg/platform/centos/centos.go
    • pkg/platform/centos/centos_test.go
    • pkg/util/constants.go
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Golangci-lint (Linter) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at mithil@platform9.com.

Documentation & Help

AI Code Review powered by Bito Logo

@tanaypf9 tanaypf9 merged commit e8d8a5a into master Sep 16, 2025
5 checks passed
@tanaypf9 tanaypf9 deleted the private/tanay/rocky branch September 16, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants