PCD-3250 :: Skin dex login page with PCD colors#55
Conversation
…tics and responsiveness, and enhance overall theme consistency.
- Replaced the existing keystone-icon.svg with a new SVG design featuring updated paths and colors. - Removed the background-size property from the .dex-btn-icon--keystone class in main.css. - Changed the favicon link in header.html from favicon.png to favicon.ico. - Added new favicon.ico files for both dark and light themes, replacing the previous favicon.png files.
Changelist by BitoThis pull request implements the following key changes.
|
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Agent Run #cd8158
Actionable Suggestions - 1
-
web/templates/password.html - 1
- Toggle password button lacks functionality implementation · Line 18-20
Additional Suggestions - 2
-
web/templates/header.html - 1
-
Misspelled HTML height attribute in logo · Line 17-17The attribute `hight` is misspelled and should be `height`. This typo will cause the height attribute to be ignored by browsers.
Code suggestion
@@ -17,1 +17,1 @@ - <img class="theme-navbar__logo" src="{{ url .ReqPath logo }}" hight="29px" width="190px"> + <img class="theme-navbar__logo" src="{{ url .ReqPath logo }}" height="29px" width="190px">
-
-
web/templates/password.html - 1
-
Duplicated eye icon URL in HTML and JavaScript · Line 51-52The `eye` variable is initialized with the same value that's already set in the HTML (line 19). This creates semantic duplication that could lead to inconsistency if one value is updated but not the other.
Code suggestion
@@ -50,7 +50,7 @@ + var icon = document.getElementById('toggle-password-icon'); -+ var eye = '{{ url .ReqPath "static/img/eye-solid-full.svg" }}'; ++ var eye = icon.getAttribute('src'); + var eyeSlash = '{{ url .ReqPath "static/img/eye-slash-solid-full.svg" }}'; + btn.addEventListener('click', function() {
-
Review Details
-
Files reviewed - 13 · Commit Range:
f36a899..f19f023- examples/example-app/templates.go
- server/templates.go
- web/static/fonts.css
- web/static/fonts/Eina-04/Licenses/Textaxis Commercial License.html
- web/static/img/eye-slash-solid-full.svg
- web/static/img/eye-solid-full.svg
- web/static/img/keystone-icon.svg
- web/static/main.css
- web/templates/header.html
- web/templates/password.html
- web/themes/dark/logo.svg
- web/themes/light/logo.svg
- web/themes/light/styles.css
-
Files skipped - 0
-
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- Golangci-lint (Linter) - ✖︎ Failed
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at mithil@platform9.com.
Documentation & Help
AI Code Review powered by
mithilarun
left a comment
mithilarun
left a comment
There was a problem hiding this comment.
Do we also need to get rid of the my-dex in the first screenshot?
|
@srm6867 why does it have the |
@mithilarun, it is due to the mock setup on my local machine. As the config that I have has a connector name of |
@mithilarun It is the name of the issuer, as specified in |
|
Bito Review Skipped - No Changes Detected |
@mithilarun We will need to update the config for dex in PCD chart repo. created tracker for this - I think, instead of renaming can we just remove this section heading? we already have Platform9 header/logo above. 
|
|
@mithilarun @vaibhsir1991 @srm6867 
|
Code Review Agent Run #2abe4fActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
4 participants
Overview
Skin dex login page with PCD colors - https://platform9.atlassian.net/browse/PCD-3250
What this PR does / why we need it
This pull request improves the DEX login page to align its design with the PCD login page.
Summary by Bito
This pull request updates the DEX login page with PCD branding, including font families, color schemes, and new assets. The changes modify the login header text to a more concise branded version and refine template structures to align with updated design guidelines. The PR enhances the password page with a visibility toggle button and adds new logo assets for both dark and light themes to ensure consistent branding.