KAAP-712:Add customername in keystone config , KAAP-295: replace "_" with "-" in group names

[srm6867]

1. ISSUE: Group name generation in keystone connector for dex token was using customer name from keystone host url.
   Fix: added optional new field customername in keystone config.

2. Fixed issue with _ in the domain/tenant names, replacing it with "-"

TESTING

configured dex with -

connectors:
- config:
    domain: default
    customerName: airctl-1-3835425-559
    keystoneHost: http://keystone-internal.airctl-1-3835425-559.svc:5000/keystone
    keystonePassword: <>
    keystoneUsername: <>
  id: default
  name: default
  type: keystone
issuer: https://airctl-1-3835425-559.platform9.localnet/dex

dex login worked and the token generated with the group names -

  "email": "admin@airctl.localnet",
  "email_verified": true,
  "groups": [
    "airctl-1-3835425-559-default-service-admin",
    "airctl-1-3835425-559-default-service-member",
    "airctl-1-3835425-559-default-service-reader"
  ],
  "name": "admin@airctl.localnet"

Overview

What this PR does / why we need it

Special notes for your reviewer

Does this PR introduce a user-facing change?

Summary by Bito

This pull request enhances the keystone connector by removing customerName validation, implementing a dynamic approach to obtain customer names when missing, and adding InsecureSkipVerify configuration. It standardizes group naming by replacing underscores with hyphens for consistency, improving security, flexibility, and maintainability across the system.

[bito-code-review]

Changelist by Bito

This pull request implements the following key changes.

Key Change	Files Impacted
New Feature - Added Config Parameters	- keystone.go - Introduced TLS configuration with insecure skip verify option and added customerName field in config, enabling more flexible keystone connections.
Feature Improvement - Enhanced Group Naming	- keystone.go - Updated group naming logic to use customerName and normalized domain and project names by replacing underscores with hyphens.

[bito-code-review]

Code Review Agent Run #35b8fc

Actionable Suggestions - 3

• connector/keystone/keystone.go - 3

  • HTTP client missing timeout configuration · Line 184-192
  • Missing validation for CustomerName before usage · Line 554-558
  • Missing empty check for customerName parameter · Line 593-600

Additional Suggestions - 1

• connector/keystone/keystone.go - 1

  • Added unused field to conn struct · Line 26-26

Review Details

• Files reviewed - 1 · Commit Range: b1673c4..1083bbf

  • connector/keystone/keystone.go
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at mithil@platform9.com.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[bito-code-review]

Code Review Agent Run #99bd4d

Actionable Suggestions - 0

Review Details

• Files reviewed - 1 · Commit Range: 1083bbf..e05050c

  • connector/keystone/keystone.go
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at mithil@platform9.com.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by