Skip to content

KAAP-295 replace "_" with "-" in tenant group name#36

Closed
srm6867 wants to merge 1 commit intomasterfrom
private/shubham/master/KAAP-295
Closed

KAAP-295 replace "_" with "-" in tenant group name#36
srm6867 wants to merge 1 commit intomasterfrom
private/shubham/master/KAAP-295

Conversation

@srm6867
Copy link
Copy Markdown

@srm6867 srm6867 commented Apr 6, 2025

Overview

What this PR does / why we need it

Special notes for your reviewer

Does this PR introduce a user-facing change?


Summary by Bito

This PR refactors tenant group name generation in the keystone connector by standardizing string manipulation. It converts domain and project names to lowercase and replaces underscores with hyphens for consistency. The changes use local variables to improve code readability and maintainability.

Unit tests added: False

Estimated effort to review (1-5, lower is better): 1

@bito-code-review
Copy link
Copy Markdown

bito-code-review bot commented Apr 6, 2025

Code Review Agent Run #119006

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 8de0061..8de0061
    • connector/keystone/keystone.go
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at mithil@platform9.com.

Documentation & Help

AI Code Review powered by Bito Logo

@bito-code-review
Copy link
Copy Markdown

Changelist by Bito

This pull request implements the following key changes.

Key Change Files Impacted
Feature Improvement - Refactored String Formatting for Standardized Tenant Naming

keystone.go - Updated the function to convert domain and project names to lowercase and replace underscores with hyphens, ensuring consistent tenant group naming.

Copy link
Copy Markdown

@indradhanush indradhanush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this backwards compatible?

@srm6867
Copy link
Copy Markdown
Author

srm6867 commented Oct 13, 2025

This is fixed with this PR - https://github.com/platform9/dex/pull/37/files
closing this one.

@srm6867 srm6867 closed this Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants