KAAP-295 replace "_" with "-" in tenant group name#36
Closed
Conversation
Code Review Agent Run #119006Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help |
Changelist by BitoThis pull request implements the following key changes.
|
Author
|
This is fixed with this PR - https://github.com/platform9/dex/pull/37/files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
What this PR does / why we need it
Special notes for your reviewer
Does this PR introduce a user-facing change?
Summary by Bito
This PR refactors tenant group name generation in the keystone connector by standardizing string manipulation. It converts domain and project names to lowercase and replaces underscores with hyphens for consistency. The changes use local variables to improve code readability and maintainability.Unit tests added: False
Estimated effort to review (1-5, lower is better): 1