Add "testPreventConvertIntToUtf8" to StringTest #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hod. fix: to prevent time conflicts at Convert::version() set the default timezone "UTC" at the setUp() function
1) ts3phpframework\src\Helper\Convert.php:89 Implicit conversion from float 90.083 to int loses precision https://www.php.net/manual/en/migration81.deprecated.php change to explicit integer conversion
add test cases for negative time format. So it's possible to handle negative seconds
|
I found a few more changes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test for convert issue at #212
It looks like the PR #222 will fix the issue