Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting empty Uint8Arrays #181

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

emmatown
Copy link
Contributor

Empty Uint8Arrays are currently formatted as 0x which isn't a hexadecimal literal so this uses the x'...' syntax instead of 0x... so it's valid for an empty Uint8Array

Copy link
Contributor

@ayrton ayrton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch (ref)

@ayrton
Copy link
Contributor

ayrton commented Jul 26, 2024

Thank you for you contribution. I'll have a look at the failing license check when I'm at my laptop

@ayrton ayrton merged commit 8e947f5 into planetscale:main Aug 12, 2024
5 checks passed
@ayrton
Copy link
Contributor

ayrton commented Aug 14, 2024

This has been released in 1.19

@planetscale planetscale deleted a comment Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants