Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle ArenaParticipant account state with diff poller #481

Merged
merged 24 commits into from
Nov 18, 2024
Merged

feat: handle ArenaParticipant account state with diff poller #481

merged 24 commits into from
Nov 18, 2024

Conversation

boscohyun
Copy link
Contributor

@boscohyun boscohyun commented Nov 12, 2024 •
edited
Loading

This resolves #472.

  • Implement Lib9c.Models.ArenaParticipant.
  • Introduce UnsupportedModelVersionException.
  • Implement ArenaParticipantDocument.
  • Implement ArenaParticipantDocumentConverter.
  • Implement and register ArenaParticipantHandler
  • Use Newtonsoft's Json library in Mimir.MongoDB project.
  • Add InsertionDate when it needed.

@boscohyun boscohyun requested review from moreal, Atralupus and a team November 12, 2024 11:01
@boscohyun boscohyun self-assigned this Nov 12, 2024
@boscohyun boscohyun requested a review from moreal November 15, 2024 02:55
@boscohyun boscohyun mentioned this pull request Nov 15, 2024
Merged
moreal
moreal previously approved these changes Nov 15, 2024
View reviewed changes
Mimir.Worker/Services/MongoDbService.cs Outdated Show resolved Hide resolved
@boscohyun
remove unused lines
c7e9d6c
@boscohyun
code clean up
a849f6a
@boscohyun
implement Lib9c.Models.ArenaParticipant with unit test
a034169
@boscohyun
introduce UnsupportedModelVersionException
cff5836
@boscohyun
implement ArenaParticipantDocument
55ff93c
@boscohyun
implement ArenaParticipantDocumentConverter
6b63214
@boscohyun
create collection if not exists when intend
03b0259
@boscohyun
implement and register ArenaParticipantHandler
040a61d
@boscohyun
use Newtonsoft's Json library in Mimir.MongoDB project
6f4159d
@boscohyun
fix verified snapshots
913e926
@boscohyun
fix ArenaParticipantHandler
a8bc40d
@boscohyun
clean up unit tests
d7154d4
@boscohyun
fix collection name as "arena_participant"
2db10db
@boscohyun
rename minor
7ae351a
@boscohyun
separate document creation method
a9d54a2
@boscohyun
add more fields to ArenaParticipantDocument
a0475c4
@boscohyun
register "arena_participant" collection name
932a7cf
@boscohyun
fix unit tests
a781e38
@boscohyun
as static
3cd5339
@boscohyun
create "InsertionDate" in MongoDbService
25aabfe
@boscohyun boscohyun force-pushed the feat/handle-arena-participant branch from 06516b8 to cb94cec Compare November 18, 2024 01:44
@boscohyun boscohyun enabled auto-merge November 18, 2024 01:46
@boscohyun
Copy link
Contributor Author

@moreal Could you review again? I've rebased this branch with new main branch head.

@boscohyun boscohyun requested a review from moreal November 18, 2024 02:47
@boscohyun boscohyun added this pull request to the merge queue Nov 18, 2024
Merged via the queue into planetarium:main with commit f480e04 Nov 18, 2024
7 checks passed
@boscohyun boscohyun deleted the feat/handle-arena-participant branch November 18, 2024 04:36
@sentry-io Sentry.io
Copy link

sentry-io bot commented Nov 21, 2024 •
edited
Loading

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moreal moreal moreal approved these changes

@Atralupus Atralupus Awaiting requested review from Atralupus

Assignees

@boscohyun boscohyun

Labels
None yet
Projects
Nine Chronicles DX Team
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle and store the ArenaParticipant account state
2 participants
@boscohyun @moreal