-
Notifications
You must be signed in to change notification settings - Fork 0
Editor refactor #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mirmirmirr
wants to merge
19
commits into
v0.1.3
Choose a base branch
from
editor-refactor
base: v0.1.3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Editor refactor #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import { MESSAGES } from "@/lib/messages"; | ||
| import submitEvent from "@/lib/utils/api/submit-event"; | ||
| import { cn } from "@/lib/utils/classname"; | ||
| import TimeRangeSelection from "./time-range/selector"; |
Check failure
Code scanning / ESLint
Disallow specified modules when loaded by `import` Error
'./time-range/selector' import is restricted from being used by a pattern. Use absolute imports with @/ prefix instead of relative parent imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors to the event editor's date/time selection and advanced options UI. The main goal was to modularize the components and clean up redundant date/time selection code so most of this is code on the backend. Some changes were also made to the mobile view of the editor.
State management + context
"SET_TIME_RANGE"into"SET_START_TIME"and"SET_END_TIME", and updated corresponding hooks for more granular time range updates. This is just to allow for more modular changes and to prevent exposing the state outside the reducerComponent modularization
@/features/selector) and then created specific selectors off of that to use in the editor.AdvancedOptionscomponent to the event editor for managing timezone, duration, and custom event code, with responsive design for mobile/desktop.DateRange and Editor Logic Refactor
DateRangeSelectionnow controls most of the display behavior and usesDateRangeDrawerandDateRangePopoverto display calendars on mobile and desktop respectively.@/features/event/editor/date-rangefolder. This included calendars and the event type selector