-
Notifications
You must be signed in to change notification settings - Fork 0
Create pull request template #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,9 @@ | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| [General description] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| ## Feature 1 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| [Description of Feature 1] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| ## Feature 2 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| [Description of Feature 2] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+1
to
+9
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| [General description] | |
| ## Feature 1 | |
| [Description of Feature 1] | |
| ## Feature 2 | |
| [Description of Feature 2] | |
| ## Description | |
| Please provide a summary of the changes and the motivation behind them. | |
| ## Type of change | |
| - [ ] Bug fix | |
| - [ ] New feature | |
| - [ ] Breaking change | |
| - [ ] Documentation update | |
| - [ ] Other (please describe): | |
| ## How Has This Been Tested? | |
| Please describe the tests that you ran to verify your changes. Provide instructions so reviewers can reproduce. Please also list any relevant details for your test configuration. | |
| ## Checklist | |
| - [ ] My code follows the style guidelines of this project | |
| - [ ] I have performed a self-review of my own code | |
| - [ ] I have commented my code, particularly in hard-to-understand areas | |
| - [ ] I have made corresponding changes to the documentation | |
| - [ ] I have added tests that prove my fix is effective or that my feature works | |
| - [ ] New and existing unit tests pass locally with my changes | |
| - [ ] Any dependent changes have been merged and published in downstream modules | |
| ## Related Issues | |
| Please link to any related issues or pull requests here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request template is located in the wrong directory path. GitHub expects pull request templates to be in
.github/PULL_REQUEST_TEMPLATE.md(as a file) or.github/PULL_REQUEST_TEMPLATE/(as a directory with template files), but the template files in the directory should NOT be namedpull_request_template.md. When using the directory approach, template files should have descriptive names likefeature_template.mdorbugfix_template.md. The current path.github/PULL_REQUEST_TEMPLATE/pull_request_template.mdis redundant and won't be automatically recognized by GitHub. Either rename this file to.github/pull_request_template.mdor place it directly as.github/PULL_REQUEST_TEMPLATE.mdfor it to be used as the default template.