Updating Main with all of the changes #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <[email protected]>
Create base project styling, start create event page functionality
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR integrates various UI improvements and updates across the frontend, including new components for date and time selection, updated theming with new fonts, and cleanup of legacy event pages.
- Introduces new components (Checkbox, Calendar, DateRangeDrawer) for improved interactivity and styling.
- Updates global CSS with new color themes and font integrations.
- Replaces outdated routes/pages with new event creation functionality.
Reviewed Changes
Copilot reviewed 19 out of 43 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| app/ui/components/checkbox.tsx | New checkbox component with hardcoded id that may need parameterization. |
| app/ui/components/archive/month-calendar.tsx | New date picker implementation with commented-out legacy code. |
| app/ui/components/archive/date-range-drawer copy.tsx | Duplicate file likely added unintentionally as indicated by “copy” in the filename. |
| app/page.tsx | Updated home page with navigation improvements. |
| app/new-event/page.tsx | New event creation page with a typo in variable naming. |
| app/layout.tsx | Updated layout with new fonts and theme providers. |
| app/globals.css | Theming improvements and new keyframes definitions with a syntax error. |
| Other files | Various utility and type definitions supporting the new functionality. |
Comments suppressed due to low confidence (2)
app/ui/components/archive/date-range-drawer copy.tsx:1
- [nitpick] The filename includes 'copy', which could indicate an accidental duplicate; consider renaming or removing this file if it is not intended for production use.
import { Drawer } from "vaul";
app/new-event/page.tsx:31
- There's a typo in the variable name 'duationOptions'; it should likely be renamed to 'durationOptions' to improve clarity.
const duationOptions = [
| <div className="flex items-center gap-2"> | ||
| <input | ||
| type="checkbox" | ||
| id="confirm" |
There was a problem hiding this comment.
Consider parameterizing or dynamically generating the 'id' instead of hardcoding 'confirm' to prevent potential conflicts when multiple checkboxes are rendered.
Comment on lines
+32
to
+48
| // const [fromValue, setFromValue] = useState<string>(""); | ||
| // const [toValue, setToValue] = useState<string>(""); | ||
|
|
||
| // const handleFromChange: ChangeEventHandler<HTMLInputElement> = (e) => { | ||
| // setFromValue(e.target.value); | ||
| // const date = parse(e.target.value, "EEE, MMM d", new Date()); | ||
| // if (!isValid(date)) { | ||
| // return setSelectedRange({ from: undefined, to: undefined }); | ||
| // } | ||
| // if (selectedRange?.to && isAfter(date, selectedRange.to)) { | ||
| // setSelectedRange({ from: selectedRange.to, to: date }); | ||
| // } else { | ||
| // setSelectedRange({ from: date, to: selectedRange?.to }); | ||
| // } | ||
| // }; | ||
|
|
||
| // const handleToChange: ChangeEventHandler<HTMLInputElement> = (e) => { |
There was a problem hiding this comment.
[nitpick] Remove or properly document the commented-out code block if it is no longer needed to improve code clarity.
Suggested change
| // const [fromValue, setFromValue] = useState<string>(""); | |
| // const [toValue, setToValue] = useState<string>(""); | |
| // const handleFromChange: ChangeEventHandler<HTMLInputElement> = (e) => { | |
| // setFromValue(e.target.value); | |
| // const date = parse(e.target.value, "EEE, MMM d", new Date()); | |
| // if (!isValid(date)) { | |
| // return setSelectedRange({ from: undefined, to: undefined }); | |
| // } | |
| // if (selectedRange?.to && isAfter(date, selectedRange.to)) { | |
| // setSelectedRange({ from: selectedRange.to, to: date }); | |
| // } else { | |
| // setSelectedRange({ from: date, to: selectedRange?.to }); | |
| // } | |
| // }; | |
| // const handleToChange: ChangeEventHandler<HTMLInputElement> = (e) => { |
| transform: translateX(0); | ||
| } | ||
| } | ||
| @keyframes slideDownAndFade: { |
There was a problem hiding this comment.
The keyframes declaration for 'slideDownAndFade' uses a colon instead of an opening brace; update it to '@Keyframes slideDownAndFade {' to ensure valid CSS syntax.
Suggested change
| @keyframes slideDownAndFade: { | |
| @keyframes slideDownAndFade { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making this PR so that way with Mir's new PR, all of the new font changes and whatnot can be added to main so all of the other branches can be updated!