Skip to content

Conversation

@mirmirmirr
Copy link
Member

This pull request primarily removes several unused files and components from the codebase, focusing on cleaning up obsolete loading skeletons, utility functions, and types. Additionally, it makes minor configuration and template adjustments for consistency and better defaults.

Codebase cleanup and removal of unused files:

  • Removed unused loading skeleton components from the app/[event-code] and app/dashboard directories, including loading.tsx files for edit, painting, and dashboard pages. (app/[event-code]/edit/loading.tsxL1-L26, app/[event-code]/loading.tsxL1-L26, app/[event-code]/painting/loading.tsxL1-L28, app/dashboard/loading.tsxL1-L20)
  • Deleted the obsolete timezone file generator utility (app/_lib/timezone-file-generator.tsx).
  • Removed the unused toast provider and related toast type definition files (app/_lib/toast-provider.tsx, app/_lib/types/toast.tsx). [1] [2]
  • Eliminated unused utility functions for data fetching and validation (app/_utils/fetch-data.tsx, app/_utils/validate-data.tsx). [1] [2]
  • Deleted the unused forgot password page component (app/forgot-password/page.tsx).
  • Removed the now-unneeded dashboard page logic (app/dashboard/page.tsx).

Configuration and template improvements:

  • Updated .gitattributes to use text=auto for better cross-platform line ending handling.
  • Standardized assignees fields in GitHub issue templates to use double quotes for consistency. [1] [2] [3]

jzgom067 and others added 30 commits October 21, 2025 03:02
When the user would paint up to midnight, the generateDragSlots function would fill every slot in the day.

This is fixed by just checking if the current time is before the start time.
For that ultra-specific edge case where the user drags all the way from 12:30 AM to 12 AM the next day.
Co-Authored-By: Jack Zgombic <[email protected]>
This reverts commit 4520f65.
This reverts commit f41d631.
jzgom067 and others added 23 commits November 1, 2025 19:39
Co-Authored-By: Miranda Zheng <[email protected]>
Co-Authored-By: Miranda Zheng <[email protected]>
Arrays of buttons will be reused multiple times in the codebase. Why not make it a central type?
This houses buttons in a frosted glass container at the bottom of the screen.

All it needs is a list of buttons to display.
The comment explains what happened. Basically, this fixes the toast persistence by removing the focus after clicking.
This fixes an issue on Chrome where the focus outline would show on click.
Create centralized button component
@mirmirmirr mirmirmirr marked this pull request as ready for review November 3, 2025 02:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a major refactoring to improve code organization and maintainability by restructuring the project into a feature-based architecture with absolute imports. The changes introduce ESLint import ordering rules, consolidate styling, create reusable button components, and modernize the toast notification system.

  • Migrated from relative to absolute imports using @/ prefix
  • Reorganized code into feature-based structure (src/features/, src/core/, src/components/)
  • Created reusable button components (ActionButton, LinkButton) with loading states
  • Consolidated and split CSS files for better organization
  • Updated toast system with new types (error, copy, success, info)

Reviewed Changes

Copilot reviewed 131 out of 146 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tsconfig.json Added baseUrl for absolute imports
tailwind.config.js Removed (consolidated into CSS)
src/styles/*.css Split and reorganized styles into modular files
src/features/button/ New reusable button components with loading states
src/features/toast/ Refactored toast system with multiple types
src/features/event/ Event-related features reorganized
src/core/ Core business logic (event, availability types/utilities)
src/components/ Shared UI components
src/lib/ Utility functions and hooks
eslint.config.mjs Added import ordering and absolute import enforcement
package.json Updated dependencies and added lint:fix script
Comments suppressed due to low confidence (2)

src/features/event/info-drawer.tsx:53

  • Extra closing bracket ] in className string will cause a syntax error or invalid CSS class. Remove the stray ] after bg-panel.
    src/core/availability/utils.ts:149
  • This condition is checked after incrementing current by 15 minutes on line 142, but then used to potentially reset current back to the start time. This logic appears incorrect and could cause an infinite loop if the condition is repeatedly true, as current would never advance past start. The check on lines 150-153 that follows seems to be the intended logic. Consider removing this block or clarifying the intended behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jzgom067 jzgom067 merged commit 4850af0 into main Nov 3, 2025
12 checks passed
@jzgom067 jzgom067 deleted the main-preview branch November 3, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants