-
Notifications
You must be signed in to change notification settings - Fork 0
v0.1.2 #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.1.2 #77
Conversation
Event editor hotfixes
When the user would paint up to midnight, the generateDragSlots function would fill every slot in the day. This is fixed by just checking if the current time is before the start time.
For that ultra-specific edge case where the user drags all the way from 12:30 AM to 12 AM the next day.
Co-Authored-By: Jack Zgombic <[email protected]>
Fix midnight painting bug
…into main-preview
This reverts commit 4520f65.
This reverts commit f41d631.
Co-Authored-By: Miranda Zheng <[email protected]>
Co-Authored-By: Miranda Zheng <[email protected]>
Co-Authored-By: Miranda Zheng <[email protected]>
Co-Authored-By: Miranda Zheng <[email protected]>
Co-Authored-By: Miranda Zheng <[email protected]>
Centralize accent color
Co-Authored-By: Miranda Zheng <[email protected]>
Toast Refactor
Arrays of buttons will be reused multiple times in the codebase. Why not make it a central type?
This houses buttons in a frosted glass container at the bottom of the screen. All it needs is a list of buttons to display.
The comment explains what happened. Basically, this fixes the toast persistence by removing the focus after clicking.
This fixes an issue on Chrome where the focus outline would show on click.
Create centralized button component
Toast persistence bug fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a major refactoring to improve code organization and maintainability by restructuring the project into a feature-based architecture with absolute imports. The changes introduce ESLint import ordering rules, consolidate styling, create reusable button components, and modernize the toast notification system.
- Migrated from relative to absolute imports using
@/prefix - Reorganized code into feature-based structure (
src/features/,src/core/,src/components/) - Created reusable button components (
ActionButton,LinkButton) with loading states - Consolidated and split CSS files for better organization
- Updated toast system with new types (error, copy, success, info)
Reviewed Changes
Copilot reviewed 131 out of 146 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Added baseUrl for absolute imports |
| tailwind.config.js | Removed (consolidated into CSS) |
| src/styles/*.css | Split and reorganized styles into modular files |
| src/features/button/ | New reusable button components with loading states |
| src/features/toast/ | Refactored toast system with multiple types |
| src/features/event/ | Event-related features reorganized |
| src/core/ | Core business logic (event, availability types/utilities) |
| src/components/ | Shared UI components |
| src/lib/ | Utility functions and hooks |
| eslint.config.mjs | Added import ordering and absolute import enforcement |
| package.json | Updated dependencies and added lint:fix script |
Comments suppressed due to low confidence (2)
src/features/event/info-drawer.tsx:53
- Extra closing bracket
]in className string will cause a syntax error or invalid CSS class. Remove the stray]afterbg-panel.
src/core/availability/utils.ts:149 - This condition is checked after incrementing
currentby 15 minutes on line 142, but then used to potentially resetcurrentback to the start time. This logic appears incorrect and could cause an infinite loop if the condition is repeatedly true, ascurrentwould never advance paststart. The check on lines 150-153 that follows seems to be the intended logic. Consider removing this block or clarifying the intended behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This pull request primarily removes several unused files and components from the codebase, focusing on cleaning up obsolete loading skeletons, utility functions, and types. Additionally, it makes minor configuration and template adjustments for consistency and better defaults.
Codebase cleanup and removal of unused files:
app/[event-code]andapp/dashboarddirectories, includingloading.tsxfiles for edit, painting, and dashboard pages. (app/[event-code]/edit/loading.tsxL1-L26, app/[event-code]/loading.tsxL1-L26, app/[event-code]/painting/loading.tsxL1-L28, app/dashboard/loading.tsxL1-L20)app/_lib/timezone-file-generator.tsx).app/_lib/toast-provider.tsx,app/_lib/types/toast.tsx). [1] [2]app/_utils/fetch-data.tsx,app/_utils/validate-data.tsx). [1] [2]app/forgot-password/page.tsx).app/dashboard/page.tsx).Configuration and template improvements:
.gitattributesto usetext=autofor better cross-platform line ending handling.assigneesfields in GitHub issue templates to use double quotes for consistency. [1] [2] [3]