-
Notifications
You must be signed in to change notification settings - Fork 0
ESLint workflow for PRs and result upload #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added ESLint workflow to run on all pull requests and added conditional for uploading results.
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds ESLint and Prettier integration to the CI/CD pipeline by creating a new code quality workflow that runs on all pull requests and pushes to main branches. The workflow outputs results in SARIF format for GitHub's security events.
- Added ESLint/Prettier workflow to run on PRs and main branch pushes
- Integrated Prettier as an ESLint plugin with error-level enforcement
- Added CodeQL Advanced workflow for security scanning
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Added ESLint formatters and Prettier plugin dependencies |
| eslint.config.mjs | Integrated Prettier plugin into ESLint configuration |
| app/ui/components/weekday-calendar.tsx | Removed unused inDrawer parameter |
| app/ui/components/selectors/time-selector.tsx | Changed let to const for immutable array |
| README.md | Removed extra blank line |
| .github/workflows/formatting.yml | Replaced auto-formatting workflow with ESLint/Prettier checking workflow |
| .github/workflows/codeql.yml | Added CodeQL Advanced security scanning workflow |
| .gitattributes | Added line ending normalization to LF |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Is this supposed to be merging into main or main-preview? |
|
I rebased it to |
Added ESLint workflow to run on all pull requests and added conditional for uploading results.