Skip to content

Conversation

@mirmirmirr
Copy link
Member

Added ESLint workflow to run on all pull requests and added conditional for uploading results.

Added ESLint workflow to run on all pull requests and added conditional for uploading results.
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@mirmirmirr mirmirmirr marked this pull request as ready for review October 21, 2025 01:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds ESLint and Prettier integration to the CI/CD pipeline by creating a new code quality workflow that runs on all pull requests and pushes to main branches. The workflow outputs results in SARIF format for GitHub's security events.

  • Added ESLint/Prettier workflow to run on PRs and main branch pushes
  • Integrated Prettier as an ESLint plugin with error-level enforcement
  • Added CodeQL Advanced workflow for security scanning

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
package.json Added ESLint formatters and Prettier plugin dependencies
eslint.config.mjs Integrated Prettier plugin into ESLint configuration
app/ui/components/weekday-calendar.tsx Removed unused inDrawer parameter
app/ui/components/selectors/time-selector.tsx Changed let to const for immutable array
README.md Removed extra blank line
.github/workflows/formatting.yml Replaced auto-formatting workflow with ESLint/Prettier checking workflow
.github/workflows/codeql.yml Added CodeQL Advanced security scanning workflow
.gitattributes Added line ending normalization to LF

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jzgom067
Copy link
Member

Is this supposed to be merging into main or main-preview?

@mirmirmirr mirmirmirr changed the base branch from main to main-preview October 22, 2025 13:25
@mirmirmirr
Copy link
Member Author

I rebased it to main-preview

@mirmirmirr mirmirmirr changed the base branch from main-preview to main October 25, 2025 17:33
@jzgom067 jzgom067 merged commit cad1ff5 into main Oct 25, 2025
5 checks passed
@jzgom067 jzgom067 deleted the Eslint-Workflow branch October 25, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants