-
Notifications
You must be signed in to change notification settings - Fork 0
Fix build errors #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build errors #37
Conversation
They had their own weird errors, and they weren't even being used. I think it's okay to get rid of them.
This way it won't be baked into the build for users. Not like it's super sensitive information anyway.
This reverts commit f9a32b9.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request fixes ESLint build errors across the codebase by addressing type safety issues, removing unused variables and imports, and improving code quality. The changes focus on replacing any types with proper TypeScript types, cleaning up commented code, and fixing various linting violations.
Key changes:
- Added proper TypeScript type definitions for API responses and component props
- Removed unused variables, imports, and commented-out code
- Fixed environment variable references from client-side to server-side variables
- Corrected React Hook dependency arrays and ESLint violations
Reviewed Changes
Copilot reviewed 40 out of 40 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| next.config.ts | Changed environment variable from NEXT_PUBLIC_API_URL to API_URL |
| example.env | Updated environment variable name to match next.config.ts |
| app/_utils/fetch-data.tsx | Added TypeScript type definitions for all API response types |
| app/_utils/format-api-error.tsx | Replaced any type with proper ApiErrorResponse type |
| app/_utils/process-event-data.tsx | Added type safety with EventDetailsResponse type |
| app/_utils/process-dashboard-data.tsx | Added type definitions for dashboard data processing |
| app/_utils/submit-event.tsx | Added EventSubmitJsonBody type and removed any casts |
| app/_utils/validate-data.tsx | Removed unused error parameters in catch blocks |
| app/ui/layout/*.tsx | Replaced any types with proper TypeScript interfaces |
| app/ui/components/**/*.tsx | Removed unused imports, variables, and commented code |
| app/_lib/**/*.tsx | Fixed hook dependency arrays and removed unused imports |
| app/[event-code]/**/page.tsx | Centralized EventCodePageProps type definition |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mirmirmirr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This pull request fixes all the build errors being generated by ESLint.
That's it.
...and I gave the header side padding for mobile.