Tweak landing page #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And the text colors to match.
For reuse in literally one other place.
I'm honestly surprised this change wasn't needed in more locations.
This is probably the one place on the entire site that shouldn't have this.
It conflicted with the "accent color on buttons" rule.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the consistency and design of the landing page by refactoring the logo into a reusable component, fixing background color inconsistencies between light and dark modes, and standardizing the capitalization of "Plancake" throughout the application.
- Created a reusable
Logocomponent and updated references fromLogotoLogoAreain the header - Fixed background and text color inconsistencies in the "golden stack recipe" and "plan today" sections for better dark mode support
- Standardized "Plancake" capitalization and removed unnecessary "use client" directive from the landing page
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| app/ui/components/logo.tsx | New reusable Logo component extracted from header |
| app/ui/components/header/logo-area.tsx | Refactored to use new Logo component, renamed from Logo to LogoArea |
| app/ui/components/header/header.tsx | Updated import to use renamed LogoArea component |
| app/page.tsx | Removed "use client", fixed background colors, used new Logo component, capitalized "Plancake" |
| app/layout.tsx | Capitalized "Plancake" in page title |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This tackles the two items on the Project board for the landing page, with a few other tweaks as well.
Background Color Fix
There was an inconsistency in background colors between light and dark mode in the "golden stack recipe" section. This was fixed, along with the text colors to match.
New
LogoComponentThe bottom of the page had a logo-looking element that didn't look right against the new background color. I decided to take the logo from the header, turn it into a reusable component, then add it to the bottom of the landing page.
Capitalized "Plancake"
There were (somehow) only two instances of lowercase Plancake in the project. Those have been replaced.
Removed
"use client";The landing page is the one place that should NOT have this. It's all for the SEO I guess.
Removed Extraneous Red Element
The "golden stack recipe" section also had a red background on one of the emojis, which conflicted with the design language we have with accent colors on interactive elements.
Why?
Just minor tweaks to make the landing page look nice and consistent.