feat(BleDataPolling): improved vehicle away detection - #2819
Open
pkuehnel wants to merge 14 commits into
Open
Conversation
The mode a previous process left on the home battery devices is unknown after startup, e.g. when the container was killed instead of shut down gracefully or when the mode job never ran at all. As restoring normal was limited to a tracked hold or charge, such a leftover hold was never released and the battery could neither charge nor discharge. Normal is now written once after startup as long as no other mode is required. Failed writes are retried as the flag is only set on success. Also adds a test that all jobs in the scheduling jobs namespace are registered for dependency injection: an unregistered job throws on every fire, which sets its trigger to error state, so it silently never runs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…worked fix(DI): add home battery mode job
refactor(chore): use httpClientFactory throughout solution
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Debug output was enabled by the container wide UseDebugBle environment variable, so it could only be turned on for every car at once and required a container restart. TSC now requests it per command based on the new UseBleDebug column of a car, toggled on the support page. The detailed tesla-control log is returned in the new DebugOutput property and logged in the container so it is part of the downloadable BLE logs as well. As tesla-control writes both its log and its error messages to standard error, the log lines are separated by their timestamp prefix and kept out of the result message. Enabling debug also revealed that the process streams were only read after waiting for the exit: with the additional debug output the pipe buffer runs full and the process never exits. Both streams are now drained while the process is running. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
pkuehnel
force-pushed
the
fix/autoSetChargingValuesOnLeaving
branch
2 times, most recently
from
July 28, 2026 18:11
b3d952e to
f4baf68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.