Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hacky try #175

Closed
wants to merge 2 commits into from
Closed

hacky try #175

wants to merge 2 commits into from

Conversation

jhheider
Copy link
Contributor

This might fix #172. let's see what CI thinks.

closes #172

@jhheider jhheider requested a review from mxcl July 27, 2023 21:35
@jhheider
Copy link
Contributor Author

Well, alright. Green. Not tested: that the export trick actually prevents double invocation.

@jhheider jhheider mentioned this pull request Jul 27, 2023
Merged
@mxcl
Copy link
Member

mxcl commented Jul 30, 2023

I'd rather not fuck with the installer since we're deprecating it. Unless we're 99% sure this is safe.

@jhheider
Copy link
Contributor Author

I'd rather not fuck with the installer since we're deprecating it. Unless we're 99% sure this is safe.

Legitimate. Closing.

@jhheider jhheider closed this Jul 30, 2023
@jhheider jhheider deleted the trapped-double-run branch July 30, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxcl mxcl Awaiting requested review from mxcl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure .bashrc is run?
2 participants
@jhheider @mxcl