-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type annotations to smart_open #545
base: develop
Are you sure you want to change the base?
Conversation
Check out PEP 585: starting with python3.7, annotations become infinitely more readable. May be worth the wait, until we drop py3.6? |
Will that much change? From looking at that PEP, we'll go from using e.g. |
To me – yes. I don't have anything against annotations but rarely use them, because I find they obfuscate more than clarify. Cons>pros. A nicer, better integrated annotation syntax could tip the scales. Just a nice-to-have feature either way, nothing critical. |
This is still a work in progress. I'm playing around with the idea to see if it's worth it.