Proper usage of update_every in LdaMulticore #3139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous link was Matthew Hoffman's Google Scholar profile or not the official one. Use full author names in the first occurrence and first author only afterward.
and use latex symbols for original parameter names
batch=True --> update_every=0 batch=False --> update_every=1 New: update_every >= 2 (as used in ldamodel.py)
jonaschn
force-pushed
the
ldamulticore/update_every
branch
from
e080811 to
7c0b61b
Compare
|
You're on a roll @jonaschn :) |
mpenkov
reviewed
May 13, 2021
mpenkov
reviewed
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LdaMulticore offers a different API compared to
LdaModel.This is unnecessary complex.
Neither the removed
batchnor theupdate_everyparameters are documented forLdaMulticore.However, LdaMulticore inherits
update_everyfromLdaMulticoreanyway.This PR removes the
batchparameter and uses theupdate_everyparameter analog to it's usage inLdaModel:batch=Truebecomesupdate_every=0batch=Falsebecomesupdate_every=1New: update_every >= 2 (as used in ldamodel.py)