Repository navigation
Dead code cleanup - #1268
Open
grosbouddha wants to merge 6 commits into
Open
Dead code cleanup#1268grosbouddha wants to merge 6 commits into
grosbouddha wants to merge 6 commits into
Conversation
juliandescottes
approved these changes
Apr 20, 2026
juliandescottes
left a comment
juliandescottes
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the cleanup
| @@ -1 +1 @@ | |||
| npx biome check --staged --write --no-errors-on-unmatched | |||
| npm run lint | |||
Collaborator
There was a problem hiding this comment.
Same comment as on the other PR, is this intentional?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove several layers of dead code and obsolete feature remnants. No behavior change for any supported browser:
src/js/snippets.jsFunction.prototype.bindandUint32Array.prototype.fillpolyfills; both native in every browserpskl.app.isLoggedIn()always returnedfalse. Remove it plus the dead chain it gated:GalleryStorageService,StorageService.saveToGallery, the.save-public-sectionUI,SaveController.isPublic_(), and `Descriptor.isPublicRELEASE.md(described a Google AppEngine Launcher workflow no longer in use and the rest is obsolete or incorrect)NOTE: I excluded tests from the husky precommit (tests are not passing the lint) by using "npm run lint" in the precommit hook (which only runs on src/ for now).