Repository navigation
Remove Q.js lib - #1267
Merged
Merged
Remove Q.js lib#1267
Conversation
… tests which are not biomejs compliant
juliandescottes
approved these changes
Apr 20, 2026
juliandescottes
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! Now that looks like JS from 2017 or something :)
| @@ -1 +1 @@ | |||
| npx biome check --staged --write --no-errors-on-unmatched | |||
| npm run lint | |||
Collaborator
There was a problem hiding this comment.
Just checking if this is intentional.
Follow up: Noticed we are only linting on src/
We should extend to tests/ no reason not to lint and format test code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the q.js promise library in favor of native Promise:
No Q-specific features were used anywhere in app code, so the migration is pure 1:1 with no behavior changes.
The trickiest part was ensuring proper this binding where needed - constructing a Promise requires an anonymous function that shadows the enclosing this.
TESTED=Unit tests and E2E passing