Test suite update (Dec 2018) #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds and fixes Expand test #0088, see https://json-ld.org/test-suite/tests/expand-manifest.jsonld#t0088. More details here: json-ld/json-ld.org#558 and here: digitalbazaar/jsonld.js#209
See json-ld/json-ld.org#603 for discussion.
This test only seems to pass in pyLD after a fix in the 1.1 framing code. We'll enable this test later, once the 1.1 implementation is under way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR syncs up the test suite with https://github.com/json-ld/json-ld.org/tree/master/test-suite.
It's important we are as up to date with the suite as possible before commencing the 1.1 implementation. I addressed 2 issues which were outlined in the new test suite:
Please note I disabled the framing test #tg010. See the discussion here: json-ld/json-ld.org#663. It appears that while it's meant to be a 1.0 test, the fix in pyLD was implemented in the 1.1 section of the framing code. Will address later.