Update Dockerfile to copy all the python files #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you start using this quickstart as skeleton of your project but then starts to grow and split the file in multiple python files you end up having problems because the Dockerfile is not copying all those files and fails when deployed to production. Ideally it should be COPY . . and have a .dockerignore file to exclude some files but that's a bigger change for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you start using this quickstart as skeleton of your project but then starts to grow and split the file in multiple python files you end up having problems because the Dockerfile is not copying all those files and fails when deployed to production.
Ideally it should be COPY . . and have a .dockerignore file to exclude some files but that's a bigger change for now.