Skip to content

WIP: simplify interface to TWCC 1/4 #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: simplify interface to TWCC 1/4 #297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion registry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,17 @@
}

// Build constructs a single Interceptor from a InterceptorRegistry
func (r *Registry) Build(id string) (Interceptor, error) {
// The extra interceptors are added to the chain before the ones specified
// by the registry.
func (r *Registry) Build(id string, extra... Interceptor) (Interceptor, error) {

Check warning on line 19 in registry.go

View check run for this annotation

Codecov / codecov/patch

registry.go#L19 

Added line #L19 was not covered by tests
if len(r.factories) == 0 {
return &NoOp{}, nil
}

interceptors := []Interceptor{}

interceptors = append(interceptors, extra...)

Check warning on line 27 in registry.go

View check run for this annotation

Codecov / codecov/patch

registry.go#L25-L27 

Added lines #L25 - L27 were not covered by tests
for _, f := range r.factories {
i, err := f.NewInterceptor(id)
if err != nil {
Expand Down
Loading