Button: new variants #3931
Merged
Button: new variants #3931
+250
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gabrielpereirapinheiro Can we do this also for ButtonLink |
✅ Deploy Preview for gestalt ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
gabrielpereirapinheiro
changed the title
gabrielpereirapinheiro
changed the title
gabrielpereirapinheiro
changed the title
packages/gestalt-design-tokens/tokens/vr-theme-web-mapping/comp-web-color-light.json
Outdated
Show resolved
Hide resolved
packages/gestalt-design-tokens/tokens/vr-theme-web-mapping/comp-web-color-dark.json
Outdated
Show resolved
Hide resolved
|
can we document them in the docs? otherwise we cant test we wanna see in darkmode |
|
Seems broken in classic ok in VR
|
|
Check all the permutation visual checks I do! Ideally, all these has been first reviewed by you, and Im supposed to catch them as a last resource! |
|
You need to update the snapshots, Run 1. AND 2. kill the docs, run yarn build, and then run |
AlbertCarreras
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding two new variants to
buttonClassic
VR
Adding two new variants to
buttonLinkClassic
VR