Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box: fix rounding bug introduced in #3822 #3828

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Box: fix rounding bug introduced in #3822 #3828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c73dea6
more
AlbertCarreras Oct 24, 2024
df7afb7
more
AlbertCarreras Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/gestalt-datepicker/src/__snapshots__/DatePicker.jsdom.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ exports[`DatePicker Mobile Datepicker renders 1`] = `
class="react-datepicker__input-container"
>
<div
class="Jea KS5 XiG ujU zI7 iyn Hsu "
class="Jea KS5 XiG ujU xcv L4E zI7 iyn Hsu"
>
<div
class="ujU zI7 iyn Hsu "
class="ujU xcv L4E zI7 iyn Hsu"
>
<span>
<div
Expand Down Expand Up @@ -142,12 +142,12 @@ exports[`DatePicker Mobile Datepicker renders 1`] = `
<div
aria-disabled="false"
aria-label="Grabber"
class="S9z iyn e8F BG7"
class="S9z v_3 iyn e8F BG7"
role="button"
tabindex="0"
>
<div
class="haa zI7 iyn Hsu "
class="haa v_3 zI7 iyn Hsu"
style="height: 5px; width: 37px;"
/>
</div>
Expand Down
18 changes: 9 additions & 9 deletions packages/gestalt/src/Accordion/__snapshots__/ExpandableItem.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ exports[`AccordionExpandableItem renders correctly 1`] = `
className="box flexGrow marginEnd600 xsDisplayFlex xsItemsBaseline"
>
<div
className="box xsCol1200"
className="box xsCol12"
>
<div
className="Flex rowGap300 columnGap0 xsDirectionRow xsItemsCenter"
Expand Down Expand Up @@ -113,7 +113,7 @@ exports[`AccordionExpandableItem renders correctly with badge 1`] = `
className="box flexGrow marginEnd600 xsDisplayFlex xsItemsBaseline"
>
<div
className="box xsCol1200"
className="box xsCol12"
>
<div
className="Flex rowGap300 columnGap0 xsDirectionRow xsItemsCenter"
Expand Down Expand Up @@ -227,7 +227,7 @@ exports[`AccordionExpandableItem renders correctly with children 1`] = `
className="box flexGrow marginEnd600 xsDisplayFlex xsItemsBaseline"
>
<div
className="box xsCol1200"
className="box xsCol12"
>
<div
className="Flex rowGap300 columnGap0 xsDirectionRow xsItemsCenter"
Expand Down Expand Up @@ -301,7 +301,7 @@ exports[`AccordionExpandableItem renders correctly with error 1`] = `
className="box flexGrow marginEnd600 xsDisplayFlex xsItemsBaseline"
>
<div
className="box xsCol1200"
className="box xsCol12"
>
<div
className="Flex rowGap300 columnGap0 xsDirectionRow xsItemsCenter"
Expand Down Expand Up @@ -397,7 +397,7 @@ exports[`AccordionExpandableItem renders correctly with icon 1`] = `
className="box flexGrow marginEnd600 xsDisplayFlex xsItemsBaseline"
>
<div
className="box xsCol1200"
className="box xsCol12"
>
<div
className="Flex rowGap300 columnGap0 xsDirectionRow xsItemsCenter"
Expand Down Expand Up @@ -493,7 +493,7 @@ exports[`AccordionExpandableItem renders correctly with icon button 1`] = `
className="box flexGrow marginEnd600 xsDisplayFlex xsItemsBaseline"
>
<div
className="box xsCol1200"
className="box xsCol12"
>
<div
className="Flex rowGap300 columnGap0 xsDirectionRow xsItemsCenter"
Expand Down Expand Up @@ -621,7 +621,7 @@ exports[`AccordionExpandableItem renders correctly with summary 1`] = `
className="box flexGrow marginEnd600 xsDisplayFlex xsItemsBaseline"
>
<div
className="box xsCol600"
className="box xsCol6"
>
<div
className="Flex rowGap300 columnGap0 xsDirectionRow xsItemsCenter"
Expand Down Expand Up @@ -649,7 +649,7 @@ exports[`AccordionExpandableItem renders correctly with summary 1`] = `
</div>
</div>
<div
className="box marginStart600 xsCol600"
className="box marginStart600 xsCol6"
>
<div
className="Flex rowGap0 columnGap200 xsDirectionColumn"
Expand Down Expand Up @@ -748,7 +748,7 @@ exports[`AccordionExpandableItem renders correctly with when expanded 1`] = `
className="box flexGrow marginEnd600 xsDisplayFlex xsItemsBaseline"
>
<div
className="box xsCol1200"
className="box xsCol12"
>
<div
className="Flex rowGap300 columnGap0 xsDirectionRow xsItemsCenter"
Expand Down
20 changes: 10 additions & 10 deletions packages/gestalt/src/Video/__snapshots__/Controls.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,15 +85,15 @@ exports[`VideoControls for double digit minutes 1`] = `
tabIndex="-1"
>
<div
className="absolute box left0 right0 rounding200 secondary xsDisplayFlex"
className="absolute box left0 right0 rounding2 secondary xsDisplayFlex"
style={
Object {
"height": 4,
}
}
>
<div
className="box light rounding200"
className="box light rounding2"
style={
Object {
"height": "100%",
Expand Down Expand Up @@ -254,15 +254,15 @@ exports[`VideoControls for double digit seconds 1`] = `
tabIndex="-1"
>
<div
className="absolute box left0 right0 rounding200 secondary xsDisplayFlex"
className="absolute box left0 right0 rounding2 secondary xsDisplayFlex"
style={
Object {
"height": 4,
}
}
>
<div
className="box light rounding200"
className="box light rounding2"
style={
Object {
"height": "100%",
Expand Down Expand Up @@ -423,15 +423,15 @@ exports[`VideoControls for single digit minutes 1`] = `
tabIndex="-1"
>
<div
className="absolute box left0 right0 rounding200 secondary xsDisplayFlex"
className="absolute box left0 right0 rounding2 secondary xsDisplayFlex"
style={
Object {
"height": 4,
}
}
>
<div
className="box light rounding200"
className="box light rounding2"
style={
Object {
"height": "100%",
Expand Down Expand Up @@ -592,15 +592,15 @@ exports[`VideoControls for single digit seconds 1`] = `
tabIndex="-1"
>
<div
className="absolute box left0 right0 rounding200 secondary xsDisplayFlex"
className="absolute box left0 right0 rounding2 secondary xsDisplayFlex"
style={
Object {
"height": 4,
}
}
>
<div
className="box light rounding200"
className="box light rounding2"
style={
Object {
"height": "100%",
Expand Down Expand Up @@ -761,15 +761,15 @@ exports[`VideoControls rounds for partial seconds 1`] = `
tabIndex="-1"
>
<div
className="absolute box left0 right0 rounding200 secondary xsDisplayFlex"
className="absolute box left0 right0 rounding2 secondary xsDisplayFlex"
style={
Object {
"height": 4,
}
}
>
<div
className="box light rounding200"
className="box light rounding2"
style={
Object {
"height": "100%",
Expand Down
4 changes: 2 additions & 2 deletions packages/gestalt/src/Video/__snapshots__/Playhead.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,15 @@ exports[`VideoPlayhead 1`] = `
tabIndex="-1"
>
<div
className="absolute box left0 right0 rounding200 secondary xsDisplayFlex"
className="absolute box left0 right0 rounding2 secondary xsDisplayFlex"
style={
Object {
"height": 4,
}
}
>
<div
className="box light rounding200"
className="box light rounding2"
style={
Object {
"height": "100%",
Expand Down
14 changes: 7 additions & 7 deletions packages/gestalt/src/__snapshots__/Accordion.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

exports[`Accordion renders a badge correctly 1`] = `
<div
className="box default paddingX600 paddingY600 rounding400 shadow"
className="box default paddingX600 paddingY600 rounding4 shadow"
id="accordion-test"
>
<div
Expand Down Expand Up @@ -91,7 +91,7 @@ exports[`Accordion renders a badge correctly 1`] = `

exports[`Accordion renders a title correctly 1`] = `
<div
className="box default paddingX600 paddingY600 rounding400 shadow"
className="box default paddingX600 paddingY600 rounding4 shadow"
id="accordion-test"
>
<div
Expand Down Expand Up @@ -134,7 +134,7 @@ exports[`Accordion renders a title correctly 1`] = `

exports[`Accordion renders an error correctly 1`] = `
<div
className="box default paddingX600 paddingY600 rounding400 shadow"
className="box default paddingX600 paddingY600 rounding4 shadow"
id="accordion-test"
>
<div
Expand Down Expand Up @@ -205,7 +205,7 @@ exports[`Accordion renders an error correctly 1`] = `

exports[`Accordion renders an icon button correctly 1`] = `
<div
className="box default paddingX600 paddingY600 rounding400 shadow"
className="box default paddingX600 paddingY600 rounding4 shadow"
id="accordion-test"
>
<div
Expand Down Expand Up @@ -308,7 +308,7 @@ exports[`Accordion renders an icon button correctly 1`] = `

exports[`Accordion renders an icon correctly 1`] = `
<div
className="box default paddingX600 paddingY600 rounding400 shadow"
className="box default paddingX600 paddingY600 rounding4 shadow"
id="accordion-test"
>
<div
Expand Down Expand Up @@ -379,7 +379,7 @@ exports[`Accordion renders an icon correctly 1`] = `

exports[`Accordion renders content correctly 1`] = `
<div
className="box default paddingX600 paddingY600 rounding400 shadow"
className="box default paddingX600 paddingY600 rounding4 shadow"
id="accordion-test"
>
<div
Expand All @@ -400,7 +400,7 @@ exports[`Accordion renders content correctly 1`] = `

exports[`Accordion renders the base correctly 1`] = `
<div
className="box default paddingX600 paddingY600 rounding400 shadow"
className="box default paddingX600 paddingY600 rounding4 shadow"
id="accordion-test"
>
<div
Expand Down
Loading
Loading