BannerSlim: fix bug with list of children (#3948)

pinterest · Jan 16, 2025 · 165636f · 165636f
1 parent c2821d3
commit 165636f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 22 deletions.
diff --git a/packages/gestalt/src/BannerSlim.tsx b/packages/gestalt/src/BannerSlim.tsx
@@ -264,10 +264,12 @@ export default function BannerSlim({
                 </Text>
               </Fragment>
             ) : null}
-            <Fragment>
-              <Text ref={referenceRef} inline />
-              {typeof message !== 'string' && cloneElement(message, { ref: targetRef })}
-            </Fragment>
+            {message && typeof message !== 'string' ? (
+              <Fragment>
+                <Text ref={referenceRef} inline />
+                {cloneElement(message, { ref: targetRef })}
+              </Fragment>
+            ) : null}
           </Box>
         </Flex.Item>
 

diff --git a/packages/gestalt/src/__snapshots__/BannerSlim.test.tsx.snap b/packages/gestalt/src/__snapshots__/BannerSlim.test.tsx.snap
@@ -53,9 +53,6 @@ exports[`BannerSlim renders an icon with accessibility label 1`] = `
         >
           test
         </span>
-        <span
-          className="default alignStart breakWord Text fontSize300 fontWeightNormal"
-        />
       </div>
     </div>
   </div>
@@ -159,9 +156,6 @@ exports[`BannerSlim renders neutral type with message 1`] = `
         >
           test
         </span>
-        <span
-          className="default alignStart breakWord Text fontSize300 fontWeightNormal"
-        />
       </div>
     </div>
   </div>
@@ -221,9 +215,6 @@ exports[`BannerSlim renders non-neutral compact with accessibility label 1`] = `
         >
           test
         </span>
-        <span
-          className="default alignStart breakWord Text fontSize300 fontWeightNormal"
-        />
       </div>
     </div>
   </div>
@@ -261,9 +252,6 @@ exports[`BannerSlim renders primary action and dismiss button 1`] = `
         >
           test
         </span>
-        <span
-          className="default alignStart breakWord Text fontSize300 fontWeightNormal"
-        />
       </div>
     </div>
     <div
@@ -445,9 +433,6 @@ exports[`BannerSlim renders simple message with helper link 1`] = `
             </a>
           </span>
         </span>
-        <span
-          className="default alignStart breakWord Text fontSize300 fontWeightNormal"
-        />
       </div>
     </div>
   </div>

diff --git a/packages/gestalt/src/__snapshots__/TableRowDrawer.test.tsx.snap b/packages/gestalt/src/__snapshots__/TableRowDrawer.test.tsx.snap
@@ -228,9 +228,6 @@ exports[`renders correctly with drawer 1`] = `
                     >
                       Test BannerSlim
                     </span>
-                    <span
-                      className="default alignStart breakWord Text fontSize300 fontWeightNormal"
-                    />
                   </div>
                 </div>
               </div>
-Original file line number
+Diff line change
@@ Expand Up @@
             >
               test
             </span>
-            <span
-              className="default alignStart breakWord Text fontSize300 fontWeightNormal"
-            />
           </div>
         </div>
       </div>
@@ Expand Down Expand Up @@
             >
               test
             </span>
-            <span
-              className="default alignStart breakWord Text fontSize300 fontWeightNormal"
-            />
           </div>
         </div>
       </div>
@@ Expand Down Expand Up @@
             >
               test
             </span>
-            <span
-              className="default alignStart breakWord Text fontSize300 fontWeightNormal"
-            />
           </div>
         </div>
       </div>
@@ Expand Down Expand Up @@
             >
               test
             </span>
-            <span
-              className="default alignStart breakWord Text fontSize300 fontWeightNormal"
-            />
           </div>
         </div>
         <div
@@ Expand Down Expand Up @@
                 </a>
               </span>
             </span>
-            <span
-              className="default alignStart breakWord Text fontSize300 fontWeightNormal"
-            />
           </div>
         </div>
       </div>
@@ Expand Down @@