[#285] Client Side gRPC Stream deadline retry refactoring #286
+523
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
feelform
commented
Mar 4, 2025
•
feelform
commented
- The stream deadline configuration is loaded from pinpoint-config-default.json
- Any value (null, undefined) should not terminate the agent because it needs to load JSON data and perform arithmetic.
5 tasks
feelform
force-pushed
the
stream-deadline-options-builder
branch
4 times, most recently
from
3d4e54a to
3f03e80
Compare
* The stream deadline configuration is loaded from pinpoint-config-default.json * Any value (null, undefined) should not terminate the agent because it needs to load JSON data and perform arithmetic * readable Stream highWaterMark = 100
feelform
force-pushed
the
stream-deadline-options-builder
branch
from
3f03e80 to
cdeec86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.