-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update image picker params for expo #1144
feat: Update image picker params for expo #1144
Conversation
Gives user ability to change quality on openImagePicker from expo-image-picker. Co-Authored-By: theBGuy <[email protected]>
Add changelog Co-Authored-By: theBGuy <[email protected]>
🦋 Changeset detectedLatest commit: 02f94ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
WalkthroughThis pull request introduces an optional Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant O as openImagePicker
participant I as ImagePicker
U->>O: Call openImagePicker({ ..., quality })
O->>I: Execute launchFn with options including quality
I-->>O: Return picked image
O-->>U: Return image result
Tip 🌐 Web search-backed reviews and chat
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🔇 Additional comments (3)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This pull request introduces changes to the
packages/expo/src/image-picker.ts
file to add a newquality
parameter to theopenImagePicker
function. Additionally, it includes a documentation update in the.changeset/quick-crabs-draw.md
file to reflect this new feature.Changes to
openImagePicker
function:quality
parameter to the options interface for the image picker, with a default value of 1. (packages/expo/src/image-picker.ts
)quality
parameter when destructuring options. (packages/expo/src/image-picker.ts
)quality
parameter to theImagePicker.launchImageLibraryAsync
function. (packages/expo/src/image-picker.ts
)Documentation update:
openImagePicker
function. (.changeset/quick-crabs-draw.md
)Summary by CodeRabbit