Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update image picker params for expo #1144

Merged

Conversation

ashaller2017
Copy link
Contributor

@ashaller2017 ashaller2017 commented Feb 5, 2025

This pull request introduces changes to the packages/expo/src/image-picker.ts file to add a new quality parameter to the openImagePicker function. Additionally, it includes a documentation update in the .changeset/quick-crabs-draw.md file to reflect this new feature.

Changes to openImagePicker function:

  • Added quality parameter to the options interface for the image picker, with a default value of 1. (packages/expo/src/image-picker.ts)
  • Updated the function to include the quality parameter when destructuring options. (packages/expo/src/image-picker.ts)
  • Passed the quality parameter to the ImagePicker.launchImageLibraryAsync function. (packages/expo/src/image-picker.ts)

Documentation update:

  • Added a changeset file to document the addition of quality parameters to the openImagePicker function. (.changeset/quick-crabs-draw.md)

Summary by CodeRabbit

  • New Features
    • Enhanced the image picker to allow users to select the desired quality of images during selection, providing more control over image resolution while maintaining a default quality setting.

ashaller2017 and others added 2 commits February 5, 2025 15:30
Gives user ability to change quality on openImagePicker from expo-image-picker.

Co-Authored-By: theBGuy <[email protected]>
Add changelog

Co-Authored-By: theBGuy <[email protected]>
Copy link

changeset-bot bot commented Feb 5, 2025

🦋 Changeset detected

Latest commit: 02f94ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@uploadthing/expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-uploadthing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 11:36pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
legacy-docs-uploadthing ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2025 11:36pm

Copy link
Contributor

coderabbitai bot commented Feb 5, 2025

Walkthrough

This pull request introduces an optional quality parameter to the openImagePicker function in the @uploadthing/expo package. The method signature was updated to include the parameter, which defaults to 1 if not provided. The internal call to the image picker now passes the quality option. Additionally, related changes were documented in the changeset to reflect this update.

Changes

File Change Summary
.changeset/quick-crabs-draw.md Documented the patch introducing the optional quality parameter to the openImagePicker function.
packages/expo/src/image-picker.ts Updated the openImagePicker signature by adding an optional quality?: number parameter (default value 1), and modified the internal call to include the quality option.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant O as openImagePicker
    participant I as ImagePicker

    U->>O: Call openImagePicker({ ..., quality })
    O->>I: Execute launchFn with options including quality
    I-->>O: Return picked image
    O-->>U: Return image result
Loading

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 00ae433 and 02f94ad.

📒 Files selected for processing (2)
  • .changeset/quick-crabs-draw.md (1 hunks)
  • packages/expo/src/image-picker.ts (3 hunks)
🔇 Additional comments (3)
packages/expo/src/image-picker.ts (2)

56-60: LGTM! Well-documented parameter.

The JSDoc documentation for the quality parameter is clear and includes the default value.


79-79: Verify the quality value range.

The implementation looks good, but we should verify if the quality parameter has any constraints on its value range (e.g., between 0 and 1).

Also applies to: 106-106

✅ Verification successful

🌐 Web query:

What is the valid range for the quality parameter in expo-image-picker?

Length of output: 1442


Verified: Quality Parameter Range is Correct

The quality parameter is correctly constrained between 0 and 1, where a value of 1 indicates the highest image quality (i.e., no compression). This applies to both the default at line 79 and the similar implementation at line 106.

.changeset/quick-crabs-draw.md (1)

1-6: LGTM! Clear and concise changeset.

The changeset correctly documents the patch update and its purpose.

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ashaller2017 ashaller2017 changed the title [Feat] - Update image picker params for expo feat - Update image picker params for expo Feb 5, 2025
@ashaller2017 ashaller2017 changed the title feat - Update image picker params for expo feat: Update image picker params for expo Feb 5, 2025
@juliusmarminge juliusmarminge merged commit 511dc21 into pingdotgg:main Feb 12, 2025
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants