-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fixywixy #1140
docs: fixywixy #1140
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
WalkthroughThis pull request involves several updates across different files in the documentation project. The changes primarily focus on dependency version upgrades in the Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@@ -51,13 +51,13 @@ export default function ScalarApiRef() { | |||
|
|||
const ref = useRef<HTMLDivElement>(null); | |||
useMutationObserver(ref, (args) => { | |||
console.log("args", args); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.log("args", args); |
@@ -56,8 +56,7 @@ export default function ScalarApiRef() { | |||
(a) => | |||
a.type === "attributes" && | |||
a.target instanceof Element && | |||
a.target.classList.contains("scalar-app") && | |||
a.target.classList.contains("references-layout"), | |||
a.target.classList.contains("references-rendered"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @marclave can we have some onLoaded
prop or <Suspense>
support so we don't have to do this hacky mutation observer thing to unmount the loading state that's fragile to break when updating the package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here you go
📦 Bundle size comparison
|
Summary by CodeRabbit