fix: allow nested objects in JsonArray type (#1127)

pingdotgg · Jan 10, 2025 · f08b20e · f08b20e
1 parent c600997
commit f08b20e
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 1 deletion.
diff --git a/.changeset/good-tables-jump.md b/.changeset/good-tables-jump.md
@@ -0,0 +1,6 @@
+---
+"uploadthing": patch
+"@uploadthing/shared": patch
+---
+
+fix: allow deeply nested objects when using JsonArray
diff --git a/packages/shared/src/types.ts b/packages/shared/src/types.ts
@@ -3,8 +3,8 @@ import type { MimeType } from "@uploadthing/mime-types";
 import type { AllowedFileType } from "./file-types";
 
 export type JsonValue = string | number | boolean | null | undefined;
-export type JsonArray = JsonValue[];
 export type JsonObject = { [key: string]: JsonValue | JsonObject | JsonArray };
+export type JsonArray = (JsonValue | JsonObject)[];
 export type Json = JsonValue | JsonObject | JsonArray;
 
 export type Overwrite<T, U> = Omit<T, keyof U> & U;

diff --git a/packages/uploadthing/test/upload-builder.test.ts b/packages/uploadthing/test/upload-builder.test.ts
@@ -146,3 +146,14 @@ it("smoke", async () => {
   });
   expect(metadata).toEqual({ header1: "woohoo", userId: "123" });
 });
+
+it("allows nested structure in output", () => {
+  const f = createBuilder<{ req: Request; res: undefined; event: undefined }>();
+
+  f(["image"]).onUploadComplete(() => {
+    return {
+      foo: "br",
+      arr: [{ bar: "baz" }],
+    };
+  });
+});