Skip to content

Add Linux Ctrl+= alias for Zoom In shortcut#854

Closed
Mohatje wants to merge 1 commit intopingdotgg:mainfrom
Mohatje:fix/linux-zoom-bind
Closed

Add Linux Ctrl+= alias for Zoom In shortcut#854
Mohatje wants to merge 1 commit intopingdotgg:mainfrom
Mohatje:fix/linux-zoom-bind

Conversation

@Mohatje
Copy link

@Mohatje Mohatje commented Mar 10, 2026

Closes #852

What Changed

  • added a Linux-only menu item to register Ctrl+= as a zoom-in alias

Why

  • Ctrl + = is expected as the keybind to zoom-in without having to press Ctrl and shift at the same time.

Checklist

  • [ x ] This PR is small and focused
  • [ x ] I explained what changed and why
  • [ N/A ] I included before/after screenshots for any UI changes
  • [ N/A ] I included a video for animation/interaction changes

Note

Add Ctrl+= as a Linux alias for the Zoom In shortcut

On Linux, Ctrl++ and Ctrl+= are distinct key combinations, so the standard zoom-in accelerator misses the = key. A hidden menu item with role: zoomIn and accelerator: Ctrl+= is conditionally added in main.ts when process.platform === 'linux'.

📊 Macroscope summarized b48f99d. 1 file reviewed, 1 issue evaluated, 0 issues filtered, 1 comment posted

🗂️ Filtered Issues

- register a hidden Linux-only `Ctrl+=` accelerator mapped to `zoomIn`
- keeps existing menus unchanged while fixing expected zoom shortcut behavior
@coderabbitai
Copy link

coderabbitai bot commented Mar 10, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b6a676bf-b773-4df6-80c8-8bc3e39794fe

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the vouch:unvouched PR author is not yet trusted in the VOUCHED list. label Mar 10, 2026
Comment on lines +590 to 600
...(process.platform === "linux"
? [
{
label: "Zoom In Alias",
accelerator: "Ctrl+=",
role: "zoomIn" as const,
visible: false,
},
]
: []),
{ role: "windowMenu" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium src/main.ts:590

The Zoom In Alias menu item is added to the top-level menu template with visible: false, but Electron ignores this property on Linux top-level items. As a result, users see a literal "Zoom In Alias" entry in the menu bar (File Edit View Zoom In Alias Window Help). Place this item inside the View submenu instead, where visible: false is respected.

-    { role: "viewMenu" },
-    ...(process.platform === "linux"
-      ? [
-          {
-            label: "Zoom In Alias",
-            accelerator: "Ctrl+=",
-            role: "zoomIn" as const,
-            visible: false,
-          },
-        ]
-      : []),
-    { role: "windowMenu" },
🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file apps/desktop/src/main.ts around lines 590-600:

The `Zoom In Alias` menu item is added to the top-level menu template with `visible: false`, but Electron ignores this property on Linux top-level items. As a result, users see a literal "Zoom In Alias" entry in the menu bar (File Edit View Zoom In Alias Window Help). Place this item inside the View submenu instead, where `visible: false` is respected.

Evidence trail:
1. apps/desktop/src/main.ts lines 590-598 at REVIEWED_COMMIT: shows 'Zoom In Alias' menu item with `visible: false` added to top-level template on Linux
2. Electron issue #8703 (https://github.com/electron/electron/issues/8703): Documents that `visible`/`enabled` properties don't work for top-level menu items, closed as wontfix with explanation about architectural limitation

@SuperComboGamer
Copy link

#406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linux desktop: Ctrl+= does not trigger native Electron zoom-in

3 participants