-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat(web): add extensible command palette #1103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
7bef645
17073d5
869181f
897b9ed
e7ffca4
cefe926
ea52bb3
c6a9033
7bc39e6
1b13b76
f546911
366dae5
a1b5299
bd703a0
75258e1
36a8834
90efe4a
b1068fe
22ffaf3
2bf6f66
5bb9824
9af2ae9
5ff0686
0d90e59
907b4c3
39149e8
9d976b1
50d149b
587e1f7
835e80a
cdcf939
d836174
4884b42
65ab9e3
4bcb1b5
57c5f7d
10d436e
d86c11a
0cb4b2b
87ee5aa
8e22d9b
761a81e
f49a6d0
4909e9b
938771b
2914502
e636664
9d569bd
0e09795
b889cb2
0fffcb9
d40ae96
f753e04
be4305b
f2b990f
646d05b
32bf2fd
8ac8b37
239c552
7456385
d0b529d
0c7f965
4519891
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -70,6 +70,7 @@ export const DEFAULT_KEYBINDINGS: ReadonlyArray<KeybindingRule> = [ | |
| { key: "mod+n", command: "terminal.new", when: "terminalFocus" }, | ||
| { key: "mod+w", command: "terminal.close", when: "terminalFocus" }, | ||
| { key: "mod+d", command: "diff.toggle", when: "!terminalFocus" }, | ||
| { key: "mod+k", command: "commandPalette.toggle", when: "!terminalFocus" }, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think there's probably justification for triggering the command pallette even when the terminal is open. I doubt mod+k is gonna be a terminal keyboard shortcut, but I could see myself working in the terminal and wanting to navigate away and it being annoying to click out to focus the window
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah true, this wasn't something i've considered, as I have previously seen the two as two different states of interaction.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The main time I would run into it I think is if I'm working on two worktrees of the same thing (like T3 Code). I will usually have my dev command running into the terminal on the worktree I was last testing, then I'll kill that command and want to navigate to the next worktree I need to check on and run the command there. Being able to Ctrl+K would be useful there (and also how I've been doing it in my command pallette branch) |
||
| { key: "mod+n", command: "chat.new", when: "!terminalFocus" }, | ||
| { key: "mod+shift+o", command: "chat.new", when: "!terminalFocus" }, | ||
| { key: "mod+shift+n", command: "chat.newLocal", when: "!terminalFocus" }, | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.