fix: timer stops counting when waiting for user input (#1069)#1074
fix: timer stops counting when waiting for user input (#1069)#1074Saikrishna1876 wants to merge 5 commits intopingdotgg:mainfrom
Conversation
- Excludes user input wait time from work duration in UI - Increases timeouts in app-server and tests for reliability
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 717d800847
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e3a7e9f257
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Screen.Recording.2026-03-14.at.17.36.44.movAgent working normally and it's time is being counted. ☝️ Screen.Recording.2026-03-14.at.17.36.11.movAgent is waiting for the user and the time counter is paused. ☝️ |
Summary
This PR fixes issue #1069 where the "Working..." timer continued to count even while the agent was waiting for user input.
Changes:
isWorkingstate inChatViewto exclude phases where the agent is waiting for user input.formatTurnWorkElapsedExcludingUserInputWaithelper to accurately calculate "Worked for" duration by subtracting intervals spent waiting for user feedback.app-serverand test suites to prevent flakiness during long-running operations.Verification:
/Users/saikrishnaambeti/Documents/Screenshots/Screen Screen Recording 2026-03-14 at 17.36.11.mov/Users/saikrishnaambeti/Documents/Screenshots/Screen Screen Recording 2026-03-14 at 17.36.44.movThis PR adheres to the @CONTRIBUTING.md guidelines:
Note
Fix timer to stop counting while waiting for user input
deriveUserInputWaitIntervalsandformatTurnWorkElapsedExcludingUserInputWaitto session-logic.ts to compute and format working time with user-input wait periods subtracted.'waiting'row variant to MessagesTimeline.tsx that renders an animated 'Waiting for you' indicator when the agent is blocked on user input.Macroscope summarized a52aa83.