Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions apps/web/src/composerDraftStore.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,8 @@ describe("composerDraftStore setModel", () => {
draftsByThreadId: {},
draftThreadsByThreadId: {},
projectDraftThreadIdByProjectId: {},
lastSelectedModel: null,
lastSelectedProvider: null,
});
});

Expand All @@ -384,6 +386,23 @@ describe("composerDraftStore setModel", () => {
"gpt-5.3-codex",
);
});

it("updates lastSelectedModel when a non-null model is set", () => {
const store = useComposerDraftStore.getState();

store.setModel(threadId, "gpt-5.3-codex");

expect(useComposerDraftStore.getState().lastSelectedModel).toBe("gpt-5.3-codex");
});

it("does not update lastSelectedModel when model is set to null", () => {
const store = useComposerDraftStore.getState();

store.setModel(threadId, "gpt-5.3-codex");
store.setModel(threadId, null);

expect(useComposerDraftStore.getState().lastSelectedModel).toBe("gpt-5.3-codex");
});
});

describe("composerDraftStore setProvider", () => {
Expand All @@ -394,6 +413,8 @@ describe("composerDraftStore setProvider", () => {
draftsByThreadId: {},
draftThreadsByThreadId: {},
projectDraftThreadIdByProjectId: {},
lastSelectedModel: null,
lastSelectedProvider: null,
});
});

Expand All @@ -413,6 +434,14 @@ describe("composerDraftStore setProvider", () => {

expect(useComposerDraftStore.getState().draftsByThreadId[threadId]).toBeUndefined();
});

it("updates lastSelectedProvider when a non-null provider is set", () => {
const store = useComposerDraftStore.getState();

store.setProvider(threadId, "codex");

expect(useComposerDraftStore.getState().lastSelectedProvider).toBe("codex");
});
});

describe("composerDraftStore runtime and interaction settings", () => {
Expand Down
43 changes: 40 additions & 3 deletions apps/web/src/composerDraftStore.ts
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ interface PersistedComposerDraftStoreState {
draftsByThreadId: Record<ThreadId, PersistedComposerThreadDraftState>;
draftThreadsByThreadId: Record<ThreadId, PersistedDraftThreadState>;
projectDraftThreadIdByProjectId: Record<ProjectId, ThreadId>;
lastSelectedModel: string | null;
lastSelectedProvider: ProviderKind | null;
}

interface ComposerThreadDraftState {
Expand Down Expand Up @@ -130,6 +132,8 @@ interface ComposerDraftStoreState {
draftsByThreadId: Record<ThreadId, ComposerThreadDraftState>;
draftThreadsByThreadId: Record<ThreadId, DraftThreadState>;
projectDraftThreadIdByProjectId: Record<ProjectId, ThreadId>;
lastSelectedModel: string | null;
lastSelectedProvider: ProviderKind | null;
getDraftThreadByProjectId: (projectId: ProjectId) => ProjectDraftThread | null;
getDraftThread: (threadId: ThreadId) => DraftThreadState | null;
setProjectDraftThreadId: (
Expand Down Expand Up @@ -185,6 +189,8 @@ const EMPTY_PERSISTED_DRAFT_STORE_STATE: PersistedComposerDraftStoreState = {
draftsByThreadId: {},
draftThreadsByThreadId: {},
projectDraftThreadIdByProjectId: {},
lastSelectedModel: null,
lastSelectedProvider: null,
};

const EMPTY_IMAGES: ComposerImageAttachment[] = [];
Expand Down Expand Up @@ -386,7 +392,13 @@ function normalizePersistedComposerDraftState(value: unknown): PersistedComposer
}
}
if (!rawDraftMap || typeof rawDraftMap !== "object") {
return { draftsByThreadId: {}, draftThreadsByThreadId, projectDraftThreadIdByProjectId };
return {
draftsByThreadId: {},
draftThreadsByThreadId,
projectDraftThreadIdByProjectId,
lastSelectedModel: null,
lastSelectedProvider: null,
};
}
const nextDraftsByThreadId: PersistedComposerDraftStoreState["draftsByThreadId"] = {};
for (const [threadId, draftValue] of Object.entries(rawDraftMap as Record<string, unknown>)) {
Expand Down Expand Up @@ -450,10 +462,17 @@ function normalizePersistedComposerDraftState(value: unknown): PersistedComposer
...(codexFastMode ? { codexFastMode } : {}),
};
}
const lastSelectedModel =
typeof candidate.lastSelectedModel === "string"
? (normalizeModelSlug(candidate.lastSelectedModel) ?? null)
: null;
const lastSelectedProvider = normalizeProviderKind(candidate.lastSelectedProvider);
return {
draftsByThreadId: nextDraftsByThreadId,
draftThreadsByThreadId,
projectDraftThreadIdByProjectId,
lastSelectedModel,
lastSelectedProvider,
};
}

Expand Down Expand Up @@ -563,6 +582,8 @@ export const useComposerDraftStore = create<ComposerDraftStoreState>()(
draftsByThreadId: {},
draftThreadsByThreadId: {},
projectDraftThreadIdByProjectId: {},
lastSelectedModel: null,
lastSelectedProvider: null,
getDraftThreadByProjectId: (projectId) => {
if (projectId.length === 0) {
return null;
Expand Down Expand Up @@ -841,7 +862,13 @@ export const useComposerDraftStore = create<ComposerDraftStoreState>()(
} else {
nextDraftsByThreadId[threadId] = nextDraft;
}
return { draftsByThreadId: nextDraftsByThreadId };
const nextState: Partial<ComposerDraftStoreState> = {
draftsByThreadId: nextDraftsByThreadId,
};
if (normalizedProvider !== null) {
nextState.lastSelectedProvider = normalizedProvider;
}
return nextState;
});
},
setModel: (threadId, model) => {
Expand All @@ -868,7 +895,13 @@ export const useComposerDraftStore = create<ComposerDraftStoreState>()(
} else {
nextDraftsByThreadId[threadId] = nextDraft;
}
return { draftsByThreadId: nextDraftsByThreadId };
const nextState: Partial<ComposerDraftStoreState> = {
draftsByThreadId: nextDraftsByThreadId,
};
if (normalizedModel !== null) {
nextState.lastSelectedModel = normalizedModel;
}
return nextState;
});
},
setRuntimeMode: (threadId, runtimeMode) => {
Expand Down Expand Up @@ -1255,6 +1288,8 @@ export const useComposerDraftStore = create<ComposerDraftStoreState>()(
draftsByThreadId: persistedDraftsByThreadId,
draftThreadsByThreadId: state.draftThreadsByThreadId,
projectDraftThreadIdByProjectId: state.projectDraftThreadIdByProjectId,
lastSelectedModel: state.lastSelectedModel,
lastSelectedProvider: state.lastSelectedProvider,
};
},
merge: (persistedState, currentState) => {
Expand All @@ -1270,6 +1305,8 @@ export const useComposerDraftStore = create<ComposerDraftStoreState>()(
draftsByThreadId,
draftThreadsByThreadId: normalizedPersisted.draftThreadsByThreadId,
projectDraftThreadIdByProjectId: normalizedPersisted.projectDraftThreadIdByProjectId,
lastSelectedModel: normalizedPersisted.lastSelectedModel,
lastSelectedProvider: normalizedPersisted.lastSelectedProvider,
};
},
},
Expand Down
10 changes: 10 additions & 0 deletions apps/web/src/hooks/useHandleNewThread.ts
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,9 @@ export function useHandleNewThread() {
const threadId = newThreadId();
const createdAt = new Date().toISOString();
return (async () => {
const { lastSelectedModel, lastSelectedProvider, setModel, setProvider } =
useComposerDraftStore.getState();

setProjectDraftThreadId(projectId, threadId, {
createdAt,
branch: options?.branch ?? null,
Expand All @@ -97,6 +100,13 @@ export function useHandleNewThread() {
runtimeMode: DEFAULT_RUNTIME_MODE,
});

if (lastSelectedModel) {
setModel(threadId, lastSelectedModel);
}
if (lastSelectedProvider) {
setProvider(threadId, lastSelectedProvider);
}

await navigate({
to: "/$threadId",
params: { threadId },
Expand Down
Loading