tiup-cluster: support clearing extra data dirs automatically when destroying cluster. #2477
+132
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
For example, if using the following configs:
The default data directory is set to use
/tikv/data
as the root path, while raft logs are stored in a distinct location at/data1/raft
. However, this configuration results in thetiup-cluster destroy
command failing to remove the raft logs as intended, leading to a leak of raft data that should be cleared.This pr is introduced to make
tiup-cluster
clear extra data directories if specified.What is changed and how it works?
Two parts:
getExtraDeployDirs
and inserts them intoInstance.Dirs
when init.Check List
Tests
Code changes
Side effects
Related changes
Release notes: