Skip to content

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Jun 5, 2025

What problem does this PR solve?

Issue Number: close #61509

Problem Summary:

What changed and how does it work?

  1. Create a new function summarizeTaskResultWithError to submit summary with error.
  2. Find all existing tasks and summary them when the ttl job timeout.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that the summary for timeout TTL job is empty

@ti-chi-bot ti-chi-bot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 5, 2025
@YangKeao YangKeao requested a review from lcwangchao June 5, 2025 07:34
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 5, 2025
@YangKeao YangKeao requested a review from Defined2014 June 5, 2025 07:34
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 56.81818% with 19 lines in your changes missing coverage. Please review.

Project coverage is 75.0063%. Comparing base (ac812ca) to head (3722a94).
Report is 18 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #61518        +/-   ##
================================================
+ Coverage   73.1060%   75.0063%   +1.9002%     
================================================
  Files          1729       1752        +23     
  Lines        480681     489912      +9231     
================================================
+ Hits         351407     367465     +16058     
+ Misses       107743      99452      -8291     
- Partials      21531      22995      +1464     
Flag Coverage Δ
integration 48.8715% <0.0000%> (?)
unit 72.4119% <56.8181%> (+0.0322%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 62.8517% <ø> (+15.8940%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 6, 2025
Copy link

ti-chi-bot bot commented Jun 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, lcwangchao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,lcwangchao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 6, 2025
Copy link

ti-chi-bot bot commented Jun 6, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-06 01:15:21.29373152 +0000 UTC m=+577207.496076782: ☑️ agreed by Defined2014.
  • 2025-06-06 05:36:51.635280531 +0000 UTC m=+592897.837625795: ☑️ agreed by lcwangchao.

@YangKeao
Copy link
Member Author

YangKeao commented Jun 6, 2025

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 6, 2025
@YangKeao
Copy link
Member Author

YangKeao commented Jun 6, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 6, 2025
@YangKeao
Copy link
Member Author

YangKeao commented Jun 6, 2025

/retest

Copy link

ti-chi-bot bot commented Jun 6, 2025

@YangKeao: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/mysql-test 3722a94 link unknown /test mysql-test
idc-jenkins-ci-tidb/unit-test 3722a94 link unknown /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit 835472c into pingcap:master Jun 6, 2025
22 of 24 checks passed
joechenrh pushed a commit to joechenrh/tidb that referenced this pull request Jun 10, 2025
AilinKid pushed a commit to AilinKid/tidb that referenced this pull request Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TTL Job summary is empty when the job timeout
4 participants