Skip to content

statistics: refactor locking mechanism and enable prepared statement caching#59028

Closed
0xPoe wants to merge 2 commits intopingcap:masterfrom
0xPoe:rustin-patch-dump-stats-one-by-one
Closed

statistics: refactor locking mechanism and enable prepared statement caching#59028
0xPoe wants to merge 2 commits intopingcap:masterfrom
0xPoe:rustin-patch-dump-stats-one-by-one

Conversation

@0xPoe
Copy link
Copy Markdown
Member

@0xPoe 0xPoe commented Jan 19, 2025

What problem does this PR solve?

Issue Number: ref #57869

Problem Summary:

What changed and how does it work?

Get the lock one by one to avoid deadlock.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

…caching

Signed-off-by: Rustin170506 <techregister@pm.me>
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jan 19, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 19, 2025
@tiprow
Copy link
Copy Markdown

tiprow Bot commented Jan 19, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jan 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rustin170506, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the sig/planner SIG: Planner label Jan 19, 2025
…error logging

Signed-off-by: Rustin170506 <techregister@pm.me>
@0xPoe 0xPoe marked this pull request as ready for review January 19, 2025 10:36
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 19, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 34.61538% with 34 lines in your changes missing coverage. Please review.

Project coverage is 73.2637%. Comparing base (eb9b085) to head (0f81f66).
Report is 1 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59028        +/-   ##
================================================
+ Coverage   73.0226%   73.2637%   +0.2410%     
================================================
  Files          1684       1714        +30     
  Lines        465705     473783      +8078     
================================================
+ Hits         340070     347111      +7041     
- Misses       104699     105028       +329     
- Partials      20936      21644       +708     
Flag Coverage Δ
integration 53.2600% <ø> (?)
unit 72.2067% <34.6153%> (+0.0072%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.3241% <ø> (+0.0086%) ⬆️

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jan 19, 2025

@Rustin170506: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 0f81f66 link true /test check-dev2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@0xPoe 0xPoe closed this Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant