-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: enhance dumpStatsDeltaToKV to return updated batch updates and ensure proper sorting #58929
statistics: enhance dumpStatsDeltaToKV to return updated batch updates and ensure proper sorting #58929
Conversation
…ats collection Signed-off-by: Rustin170506 <[email protected]>
…s and ensure proper sorting Signed-off-by: Rustin170506 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #58929 +/- ##
================================================
+ Coverage 73.1217% 73.7997% +0.6780%
================================================
Files 1680 1710 +30
Lines 464543 472855 +8312
================================================
+ Hits 339682 348966 +9284
+ Misses 103984 102323 -1661
- Partials 20877 21566 +689
Flags with carried forward coverage won't be shown. Click here to find out more.
|
a9572c5
to
0d2e044
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔢 Self-check (PR reviewed by myself and ready for feedback.)
9af1d9b
to
0d2e044
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: time-and-fate, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
…s and ensure proper sorting (pingcap#58929) ref pingcap#57869
…s and ensure proper sorting (pingcap#58929) ref pingcap#57869
What problem does this PR solve?
Issue Number: ref #57869, close #58903
Problem Summary:
What changed and how does it work?
3. I also updated it to useSELECT FOR UPDATE NOWAIT
to avoid the deadlock in the first place.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.