Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add v2 Label automatically #6062

Closed
wants to merge 4 commits into from

Conversation

csuzhangxc
Copy link
Member

What problem does this PR solve?

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Copy link
Contributor

ti-chi-bot bot commented Feb 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from csuzhangxc, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested review from howardlau1999 and shonge February 7, 2025 06:39
@ti-chi-bot ti-chi-bot bot added the size/S label Feb 7, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.41%. Comparing base (012f729) to head (1a29f87).

Additional details and impacted files
@@             Coverage Diff             @@
##           feature/v2    #6062   +/-   ##
===========================================
  Coverage       69.41%   69.41%           
===========================================
  Files             153      153           
  Lines            9684     9684           
===========================================
  Hits             6722     6722           
  Misses           2962     2962           
Flag Coverage Δ
unittest 69.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@csuzhangxc csuzhangxc closed this Feb 7, 2025
@csuzhangxc csuzhangxc reopened this Feb 7, 2025
@csuzhangxc csuzhangxc closed this Feb 7, 2025
@csuzhangxc csuzhangxc reopened this Feb 7, 2025
@csuzhangxc csuzhangxc closed this Feb 8, 2025
@csuzhangxc csuzhangxc deleted the add-label-v2 branch February 8, 2025 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants