Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controllerrevision): add component into revision name #6045

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

liubog2008
Copy link
Member

  • add component name into controller revision name

@ti-chi-bot ti-chi-bot bot requested a review from shonge January 17, 2025 04:15
@ti-chi-bot ti-chi-bot bot added the size/L label Jan 17, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 62.06897% with 22 lines in your changes missing coverage. Please review.

Project coverage is 69.96%. Comparing base (65c3a1d) to head (1125967).

Additional details and impacted files
@@              Coverage Diff               @@
##           feature/v2    #6045      +/-   ##
==============================================
+ Coverage       69.94%   69.96%   +0.01%     
==============================================
  Files             154      154              
  Lines            9517     9523       +6     
==============================================
+ Hits             6657     6663       +6     
  Misses           2860     2860              
Flag Coverage Δ
unittest 69.96% <62.06%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@liubog2008 liubog2008 added the v2 for operator v2 label Jan 17, 2025
@liubog2008
Copy link
Member Author

/run-pull-e2e-kind-v2

Copy link
Contributor

ti-chi-bot bot commented Jan 17, 2025

@fgksgf: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

ti-chi-bot bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fgksgf
Once this PR has been reviewed and has the lgtm label, please ask for approval from liubog2008, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csuzhangxc csuzhangxc merged commit ae78931 into pingcap:feature/v2 Jan 17, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L v2 for operator v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants