Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove namespace in PD MS example (#6043) #6044

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #6043

What problem does this PR solve?

fix #6042

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Copy link
Contributor

ti-chi-bot bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bornchanger for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested review from howardlau1999 and shonge January 17, 2025 03:45
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.97%. Comparing base (c23a794) to head (8c9546e).
Report is 19 commits behind head on release-1.6.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.6    #6044      +/-   ##
===============================================
- Coverage        57.20%   56.97%   -0.24%     
===============================================
  Files              259      260       +1     
  Lines            33233    45033   +11800     
===============================================
+ Hits             19010    25656    +6646     
- Misses           12290    17390    +5100     
- Partials          1933     1987      +54     
Flag Coverage Δ
unittest 56.97% <ø> (-0.24%) ⬇️

@csuzhangxc csuzhangxc merged commit c51afc8 into pingcap:release-1.6 Jan 17, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants