Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix typo #6024

Merged
merged 1 commit into from
Jan 8, 2025
Merged

*: fix typo #6024

merged 1 commit into from
Jan 8, 2025

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jan 8, 2025

What problem does this PR solve?

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot ti-chi-bot bot requested a review from shonge January 8, 2025 06:57
@ti-chi-bot ti-chi-bot bot added the size/L label Jan 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 56.97%. Comparing base (a16b2e8) to head (4aaa09d).
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6024      +/-   ##
==========================================
- Coverage   57.19%   56.97%   -0.23%     
==========================================
  Files         259      260       +1     
  Lines       33233    45033   +11800     
==========================================
+ Hits        19008    25658    +6650     
- Misses      12291    17389    +5098     
- Partials     1934     1986      +52     
Flag Coverage Δ
unittest 56.97% <61.53%> (-0.23%) ⬇️

@rleungx
Copy link
Member Author

rleungx commented Jan 8, 2025

@csuzhangxc PTAL

Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 8, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Jan 8, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-08 07:45:10.680598021 +0000 UTC m=+339653.969429727: ☑️ agreed by csuzhangxc.

@ti-chi-bot ti-chi-bot bot added the approved label Jan 8, 2025
@csuzhangxc csuzhangxc merged commit bcf2c89 into pingcap:master Jan 8, 2025
6 checks passed
@csuzhangxc
Copy link
Member

/cherry-pick release-1.6

@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request created to branch release-1.6: #6025.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 8, 2025
10 tasks
@rleungx rleungx deleted the typo branch January 8, 2025 07:53
RidRisR pushed a commit to RidRisR/tidb-operator that referenced this pull request Jan 13, 2025
Signed-off-by: Ryan Leung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants