Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ut): add some uts for tiflashgroup and pd #6023

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

liubog2008
Copy link
Member

  • add uts for tiflashgroup
  • add uts for common

@ti-chi-bot ti-chi-bot bot added the size/XXL label Jan 8, 2025
@liubog2008 liubog2008 added the v2 for operator v2 label Jan 8, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 53.07%. Comparing base (1dbb5b1) to head (c3bd82c).

Additional details and impacted files
@@              Coverage Diff               @@
##           feature/v2    #6023      +/-   ##
==============================================
+ Coverage       50.57%   53.07%   +2.49%     
==============================================
  Files             154      154              
  Lines            9459     9445      -14     
==============================================
+ Hits             4784     5013     +229     
+ Misses           4675     4432     -243     
Flag Coverage Δ
unittest 53.07% <0.00%> (+2.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

ti-chi-bot bot commented Jan 8, 2025

@csuzhangxc: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

ti-chi-bot bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csuzhangxc csuzhangxc merged commit 5867afd into pingcap:feature/v2 Jan 8, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL v2 for operator v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants