Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: add a new CRD for compact backup #5822

Open
wants to merge 63 commits into
base: master
Choose a base branch
from
Open

Conversation

RidRisR
Copy link
Contributor

@RidRisR RidRisR commented Oct 28, 2024

What problem does this PR solve?

What is changed and how does it work?

Add a new CRD controls the compact backup. It will collect the log backup data and try to compact it.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

Add a new CRD controls the `compact backup`. It will collect the log backup data and try to compact it.

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 0.87719% with 791 lines in your changes missing coverage. Please review.

Project coverage is 56.01%. Comparing base (a16b2e8) to head (febaa45).
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5822      +/-   ##
==========================================
- Coverage   57.19%   56.01%   -1.19%     
==========================================
  Files         259      266       +7     
  Lines       33233    45818   +12585     
==========================================
+ Hits        19008    25664    +6656     
- Misses      12291    18170    +5879     
- Partials     1934     1984      +50     
Flag Coverage Δ
unittest 56.01% <0.87%> (-1.19%) ⬇️

@RidRisR
Copy link
Contributor Author

RidRisR commented Dec 4, 2024

/retest

@RidRisR RidRisR requested a review from WangLe1321 December 26, 2024 10:25
pkg/controller/compactbackup/compact_backup_controller.go Outdated Show resolved Hide resolved
pkg/controller/compactbackup/compact_backup_controller.go Outdated Show resolved Hide resolved
cmd/backup-manager/app/compact/manager.go Show resolved Hide resolved
pkg/controller/compact_status_updater.go Outdated Show resolved Hide resolved
cmd/backup-manager/app/compact/manager.go Outdated Show resolved Hide resolved
@RidRisR RidRisR requested a review from WangLe1321 January 7, 2025 06:07
@RidRisR RidRisR changed the title New crd for log compact br: add a new CRD for compact backup Jan 7, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 8, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: WangLe1321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 8, 2025
@ti-chi-bot ti-chi-bot bot removed the lgtm label Jan 8, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 8, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-08 02:30:12.621029089 +0000 UTC m=+320755.909860794: ☑️ agreed by WangLe1321.
  • 2025-01-08 02:33:48.628480408 +0000 UTC m=+320971.917312114: ✖️🔁 reset by ti-chi-bot[bot].

Copy link
Contributor

ti-chi-bot bot commented Jan 8, 2025

New changes are detected. LGTM label has been removed.

Copy link
Contributor

ti-chi-bot bot commented Jan 8, 2025

@RidRisR: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants