Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiproxy: support set require-backend-tls and use separate config for tiproxy HTTP port #5389

Merged
merged 6 commits into from
Nov 17, 2023

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Nov 13, 2023

What problem does this PR solve?

Latest tiproxy does not require this workaround anymore. require-backend-tls is false by default. Support resetting the config by user.

Also, support server-http-tls config, which will be used by newer tiproxy. This is set to skip-ca=true so that tiproxyctl or NLB wont need to provide any cert even if server-tls.skip-ca=false. ref pingcap/tiproxy#403

Old configs are kept as is by Get() == nil, no changes should be made.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Copy link
Contributor

ti-chi-bot bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2023

Codecov Report

Merging #5389 (25f807d) into master (d8426ec) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5389      +/-   ##
==========================================
- Coverage   61.61%   61.59%   -0.02%     
==========================================
  Files         228      228              
  Lines       28895    28901       +6     
==========================================
- Hits        17804    17803       -1     
- Misses       9347     9354       +7     
  Partials     1744     1744              
Flag Coverage Δ
unittest 61.59% <0.00%> (-0.02%) ⬇️

@xhebox xhebox enabled auto-merge (squash) November 13, 2023 07:42
@xhebox
Copy link
Contributor Author

xhebox commented Nov 13, 2023

/test all

Copy link
Contributor

ti-chi-bot bot commented Nov 13, 2023

@xhebox: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot removed the lgtm label Nov 13, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-13 06:40:49.954613662 +0000 UTC m=+4058447.541723804: ☑️ agreed by csuzhangxc.
  • 2023-11-13 15:08:56.799041744 +0000 UTC m=+4088934.386151874: ✖️🔁 reset by ti-chi-bot[bot].

Copy link
Contributor

ti-chi-bot bot commented Nov 13, 2023

New changes are detected. LGTM label has been removed.

Copy link
Contributor

ti-chi-bot bot commented Nov 16, 2023

@xhebox: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added size/S and removed size/XS labels Nov 17, 2023
@xhebox xhebox changed the title tiproxy: remove unused config tiproxy: support set require-backend-tls and use separate config for tiproxy HTTP port Nov 17, 2023
@csuzhangxc csuzhangxc disabled auto-merge November 17, 2023 06:25
@csuzhangxc csuzhangxc merged commit f3c51f1 into pingcap:master Nov 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants