-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tiproxy: support set require-backend-tls and use separate config for tiproxy HTTP port #5389
Conversation
Signed-off-by: xhe <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csuzhangxc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5389 +/- ##
==========================================
- Coverage 61.61% 61.59% -0.02%
==========================================
Files 228 228
Lines 28895 28901 +6
==========================================
- Hits 17804 17803 -1
- Misses 9347 9354 +7
Partials 1744 1744
|
/test all |
@xhebox: No presubmit jobs available for pingcap/tidb-operator@master In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[LGTM Timeline notifier]Timeline:
|
New changes are detected. LGTM label has been removed. |
@xhebox: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: xhe <[email protected]>
What problem does this PR solve?
Latest tiproxy does not require this workaround anymore.
require-backend-tls
is false by default. Support resetting the config by user.Also, support
server-http-tls
config, which will be used by newer tiproxy. This is set toskip-ca=true
so thattiproxyctl
orNLB
wont need to provide any cert even ifserver-tls.skip-ca=false
. ref pingcap/tiproxy#403Old configs are kept as is by
Get() == nil
, no changes should be made.Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.